This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Make Zfh PseudoQuietFCMP definitions predicated on HasStdExtZfh
ClosedPublic

Authored by asb on Mar 20 2023, 9:40 AM.

Details

Summary

These were previously in a Predicates = [HasStdExtZfhOrZfhmin] block, but Zfhmin has no fcmp instructions so the definition makes no sense for Zfhmin.

@craig.topper pretty sure this is just a merging / copy and paste issue based on similar logic on F and D, but thought I'd quickly double check I've not missed something here.

Diff Detail

Event Timeline

asb created this revision.Mar 20 2023, 9:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 9:40 AM
asb requested review of this revision.Mar 20 2023, 9:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 9:40 AM
craig.topper accepted this revision.Mar 20 2023, 9:59 AM

LGTM. I guess maybe I focused on the FLH/FSH and didn't notice the block needed to be split.

This revision is now accepted and ready to land.Mar 20 2023, 9:59 AM
This revision was landed with ongoing or failed builds.Mar 20 2023, 10:07 AM
This revision was automatically updated to reflect the committed changes.