[clangd] Remove reundant use of getSpellingLoc()
ClosedPublic
Actions

Authored by nridge on Sun, Mar 19, 1:04 AM.

Details

Reviewers

hokein
kadircet

Commits

rG57bfe25574a0: [clangd] Remove reundant use of getSpellingLoc()

Summary

getFileLoc() is guaranteed to return a file loc, and getSpellingLoc()
on a file loc is a no-op.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

nridge created this revision.Sun, Mar 19, 1:04 AM

Herald added a project: Restricted Project. · View Herald TranscriptSun, Mar 19, 1:04 AM

Herald added a subscriber: arphaman. · View Herald Transcript

nridge requested review of this revision.Sun, Mar 19, 1:04 AM

Herald added a project: Restricted Project. · View Herald TranscriptSun, Mar 19, 1:04 AM

Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript

No functional changes intended, this redundancy is just something I noticed while I was learning about these functions during my review of D144074 and looking at other usages of them in clnagd.

Harbormaster completed remote builds in B220271: Diff 506356.Sun, Mar 19, 1:24 AM

Thanks!

This revision is now accepted and ready to land.Mon, Mar 20, 1:36 AM

Closed by commit rG57bfe25574a0: [clangd] Remove reundant use of getSpellingLoc() (authored by nridge). · Explain WhyMon, Mar 20, 11:52 AM

This revision was automatically updated to reflect the committed changes.

nridge added a commit: rG57bfe25574a0: [clangd] Remove reundant use of getSpellingLoc().

Revision Contents
Changeset List

Path

Size

clang-tools-extra/

clangd/

FindSymbols.cpp

4 lines

XRefs.cpp

4 lines

Diff 506672

View Options

clang-tools-extra/clangd/FindSymbols.cpp