Page MenuHomePhabricator

[libc++] Use named Lit features to flag back-deployment XFAILs

Authored by ldionne on Sat, Mar 18, 7:42 AM.


Group Reviewers
Restricted Project

Instead of writing something like XFAIL: use_system_cxx_lib && target=...
to XFAIL back-deployment tests, introduce named Lit features like
availability-shared_mutex-missing to represent those. This makes the
XFAIL annotations leaner, and solves the problem of XFAIL comments
potentially getting out of sync. This would also make it easier for
another vendor to add their own annotations to the test suite by simply
changing how the feature is defined for their OS releases, instead
of having to modify hundreds of tests to add repetitive annotations.

This doesn't touch *all* annotations -- only annotations that were widely
duplicated are given named features (e.g. when filesystem or shared_mutex
were introduced). I still think it probably doesn't make sense to have a
named feature for every single fix we make to the dylib.

This is in essence a revert of 2659663, but since then the test suite
has changed significantly. Back when I did 2659663, the configuration
files we have for the test suite right now were being bootstrapped and
it wasn't clear how to provide these features for back-deployment in
that context. Since then, we have a streamlined way of defining these
features in and that doesn't impact the ability for a
configuration file to stay minimal.

The original motivation for this change was that I am about to propose
a change that would touch essentially all XFAIL annotations for back-deployment
in the test suite, and this greatly reduces the number of lines changed
by that upcoming change, in addition to making the test suite generally

Diff Detail

Event Timeline

ldionne created this revision.Sat, Mar 18, 7:42 AM
ldionne requested review of this revision.Sat, Mar 18, 7:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Mar 18, 7:42 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Sat, Mar 18, 8:46 AM
This revision is now accepted and ready to land.Sat, Mar 18, 8:46 AM
ldionne updated this revision to Diff 506311.Sat, Mar 18, 1:10 PM

Fix incorrect markup in libcxx/test/std/strings/basic.string/string.capacity/reserve_size.pass.cpp

ldionne updated this revision to Diff 506332.Sat, Mar 18, 2:15 PM

Fix a couple more incorrect XFAILs

Mordante accepted this revision.Sun, Mar 19, 11:13 AM
Mordante added a subscriber: Mordante.

I spot checked the patch, but trust on the CI to catch issues.

There's one question, other than that LGTM.


Since vendors can disable filesystem, can't you tie into the same feature?