Page MenuHomePhabricator
Differential D146226

[SCEV] Recognize vscale intrinsics
ClosedPublic
Actions

Authored by nikic on Thu, Mar 16, 6:44 AM.

Details

Reviewers
paulwalker-arm
sdesmalen
reames
Commits
rGa5242483e40c: [SCEV] Recognize vscale intrinsics
Summary

Now that SCEV has a dedicated vscale node type, we should also map vscale intrinsics to it. To make sure this does not regress ranges (which were KnownBits based previously), add support for vscale to getRangeRef() as well.

Depends on D146217.

Diff Detail

Event Timeline

nikic created this revision.Thu, Mar 16, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 16, 6:44 AM
Herald added subscribers: StephenFan, javed.absar, hiraditya. · View Herald Transcript
nikic requested review of this revision.Thu, Mar 16, 6:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 16, 6:44 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B219860: Diff 505796.Thu, Mar 16, 7:42 AM
reames accepted this revision.Thu, Mar 16, 7:44 AM

LGTM w/minor comment

llvm/include/llvm/Analysis/ValueTracking.h
657

Can you rephrase this comment? This doesn't just bound the vscale intrinsic, it also bounds the vscale type param.

This revision is now accepted and ready to land.Thu, Mar 16, 7:44 AM
Closed by commit rGa5242483e40c: [SCEV] Recognize vscale intrinsics (authored by nikic). · Explain WhyFri, Mar 17, 2:09 AM
This revision was automatically updated to reflect the committed changes.
nikic added a commit: rGa5242483e40c: [SCEV] Recognize vscale intrinsics.

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
Analysis/
4 lines
lib/
Analysis/
4 lines
2 lines
test/
Analysis/
ScalarEvolution/
12 lines

Diff 506010

View Options

llvm/include/llvm/Analysis/ValueTracking.h

Loading...
View Options

llvm/lib/Analysis/ScalarEvolution.cpp

Loading...
View Options

llvm/lib/Analysis/ValueTracking.cpp

Loading...
View Options

llvm/test/Analysis/ScalarEvolution/scalable-vector.ll

Loading...