This is an archive of the discontinued LLVM Phabricator instance.

[flang] Do not try to rebox for assumed type
ClosedPublic

Authored by clementval on Mar 16 2023, 3:15 AM.

Details

Summary

Just use conversion from assuemd type to assumed type
because a rebox needs more information that are not available
with assumed type.

Also use isAssumedType instead of isBoxNone since assumed
type can have sequence information.

Depends on D146207

Diff Detail

Event Timeline

clementval created this revision.Mar 16 2023, 3:15 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 16 2023, 3:15 AM
clementval requested review of this revision.Mar 16 2023, 3:15 AM

Add missing test

PeteSteinfeld accepted this revision.Mar 16 2023, 8:06 AM

All builds and tests correctly and (aside from the clang-format diffs) looks good. Please run clang-format before merging.

flang/lib/Optimizer/Builder/FIRBuilder.cpp
363

I got clang-format errors here.

This revision is now accepted and ready to land.Mar 16 2023, 8:06 AM

clang-format

This revision was landed with ongoing or failed builds.Mar 16 2023, 9:17 AM
This revision was automatically updated to reflect the committed changes.