This is an archive of the discontinued LLVM Phabricator instance.

Add `tosa::ConcatOp` as legal in `TosaToLinalgPass`
ClosedPublic

Authored by ramiro050 on Mar 15 2023, 3:46 PM.

Details

Summary

The lowering for tosa::ConcatOp was recently moved from
TosaToLinalg to TosaToTensor in
https://reviews.llvm.org/D145952. However, the op was not marked as
legal in the TosaToLinalgPass, resulting in legalization error when
applying TosaToLinalg to a graph with the tosa::ConcatOp.

This commit adds the op tosa::ConcatOp to the list of legal ops in
TosaToLinalgPass.

Diff Detail

Event Timeline

ramiro050 created this revision.Mar 15 2023, 3:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2023, 3:46 PM
ramiro050 requested review of this revision.Mar 15 2023, 3:46 PM

it's my fault.. https://reviews.llvm.org/D145952
I just uploaded a fix because I didn't see yours:
https://reviews.llvm.org/D146213

So you can push this one and I will push the illegal in TosaToTensor

mamrami accepted this revision.Mar 16 2023, 4:11 AM
This revision is now accepted and ready to land.Mar 16 2023, 4:11 AM

There was a bug in a test in flang but it was fixed so you can push/rebase

Update:
I pushed the fix and thanked you :)

ramiro050 closed this revision.Mar 16 2023, 8:27 AM

Thanks, @mamrami ! I will go ahead and close this.