User Details
User Details
- User Since
- Nov 3 2021, 1:13 PM (81 w, 4 d)
Apr 21 2023
Apr 21 2023
ramiro050 updated the diff for D148941: Revert "Revert "Fix handling of special and large vals in expand pattern for `round`" and "Add pattern that expands `math.roundeven` into `math.round` + arith"".
Updated tests for positive nan to also use bitcast to i32, since checking just for nan would fail to catch the case where the function erroneously outputs -nan.
ramiro050 updated the diff for D148941: Revert "Revert "Fix handling of special and large vals in expand pattern for `round`" and "Add pattern that expands `math.roundeven` into `math.round` + arith"".
Change check for -nan to a check that looks at the result bitcasted as an i32.
ramiro050 added a comment to D148941: Revert "Revert "Fix handling of special and large vals in expand pattern for `round`" and "Add pattern that expands `math.roundeven` into `math.round` + arith"".
ramiro050 added a reverting change for rG87cef78fa1c7: Revert "Fix handling of special and large vals in expand pattern for `round`"…: D148941: Revert "Revert "Fix handling of special and large vals in expand pattern for `round`" and "Add pattern that expands `math.roundeven` into `math.round` + arith"".
ramiro050 added inline comments to D148285: Add pattern that expands `math.roundeven` into `math.round` + arith.
ramiro050 added inline comments to D148285: Add pattern that expands `math.roundeven` into `math.round` + arith.
Apr 20 2023
Apr 20 2023
ramiro050 updated the diff for D148285: Add pattern that expands `math.roundeven` into `math.round` + arith.
Addressed comments
Apr 14 2023
Apr 14 2023
ramiro050 updated the summary of D148398: Fix handling of special and large vals in expand pattern for `round`.
ramiro050 added inline comments to D148398: Fix handling of special and large vals in expand pattern for `round`.
ramiro050 added reviewers for D148398: Fix handling of special and large vals in expand pattern for `round`: jpienaar, rsuderman.
ramiro050 requested review of D148398: Fix handling of special and large vals in expand pattern for `round`.
Apr 13 2023
Apr 13 2023
ramiro050 added reviewers for D148285: Add pattern that expands `math.roundeven` into `math.round` + arith: jpienaar, rsuderman.
ramiro050 requested review of D148285: Add pattern that expands `math.roundeven` into `math.round` + arith.
Mar 16 2023
Mar 16 2023
Thanks, @mamrami ! I will go ahead and close this.
Mar 15 2023
Mar 15 2023
ramiro050 added reviewers for D146174: Add `tosa::ConcatOp` as legal in `TosaToLinalgPass`: rsuderman, nicolasvasilache.
ramiro050 requested review of D146174: Add `tosa::ConcatOp` as legal in `TosaToLinalgPass`.
Mar 13 2023
Mar 13 2023
ramiro050 added a reviewer for D145986: [mlir][tosa] Swap reshape at end of reduce op with expand_shape: rsuderman.
ramiro050 requested review of D145986: [mlir][tosa] Swap reshape at end of reduce op with expand_shape.
Mar 9 2023
Mar 9 2023
ramiro050 added inline comments to D140821: [DRAFT] Generalize expand_shape to take shape as explicit input.
ramiro050 updated the diff for D140821: [DRAFT] Generalize expand_shape to take shape as explicit input.
Updating D140821: [DRAFT] Generalize expand_shape to take shape as explicit input
After talking with @sanjoy, we decided that I will finish the implementation of this patch.
Oct 13 2022
Oct 13 2022
ramiro050 updated the diff for D135828: Fix handling of rank-1 tensors in tosa.reduce_sum.
Change CHECK to CHECK-DAG for constants in test
Oct 12 2022
Oct 12 2022
ramiro050 added a reviewer for D135828: Fix handling of rank-1 tensors in tosa.reduce_sum: jpienaar.
ramiro050 requested review of D135828: Fix handling of rank-1 tensors in tosa.reduce_sum.