This is an archive of the discontinued LLVM Phabricator instance.

Differential D146067

JITLink: Add missing EHFrame NULL terminator on aarch64/ELF
ClosedPublic

Authored by tstellar on Mar 14 2023, 10:16 AM.

Details

Reviewers
lhames
v.g.vassilev
Commits
rG68c14f582ce6: JITLink: Add missing EHFrame NULL terminator on aarch64/ELF
Summary

This fixes test failures on AArch64 with libgcc-13:

Clang :: Interpreter/global-dtor.cpp
Clang-Unit :: Interpreter/./ClangReplInterpreterTests/2/4

Diff Detail

Event Timeline

tstellar created this revision.Mar 14 2023, 10:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2023, 10:16 AM
Herald added subscribers: hiraditya, kristof.beyls. · View Herald Transcript
tstellar requested review of this revision.Mar 14 2023, 10:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2023, 10:16 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
lhames accepted this revision.Mar 14 2023, 10:18 AM

LGTM. Thanks @tstellar!

This revision is now accepted and ready to land.Mar 14 2023, 10:18 AM
v.g.vassilev accepted this revision.Mar 14 2023, 10:27 AM

Nice!

Harbormaster completed remote builds in B219394: Diff 505154.Mar 14 2023, 11:17 AM
Closed by commit rG68c14f582ce6: JITLink: Add missing EHFrame NULL terminator on aarch64/ELF (authored by tstellar). · Explain WhyMar 14 2023, 4:51 PM
This revision was automatically updated to reflect the committed changes.
tstellar added a commit: rG68c14f582ce6: JITLink: Add missing EHFrame NULL terminator on aarch64/ELF.
thesamesam added a subscriber: thesamesam.Mar 14 2023, 4:52 PM

Revision Contents

PathSize
llvm/
lib/
ExecutionEngine/
JITLink/
1 line

Diff 505324

llvm/lib/ExecutionEngine/JITLink/ELF_aarch64.cpp

Show First 20 Lines • Show All 546 Lines • ▼ Show 20 Linesvoid link_ELF_aarch64(std::unique_ptr<LinkGraph> G,
PassConfiguration Config; PassConfiguration Config;
const Triple &TT = G->getTargetTriple(); const Triple &TT = G->getTargetTriple();
if (Ctx->shouldAddDefaultTargetPasses(TT)) { if (Ctx->shouldAddDefaultTargetPasses(TT)) {
// Add eh-frame passses. // Add eh-frame passses.
Config.PrePrunePasses.push_back(DWARFRecordSectionSplitter(".eh_frame")); Config.PrePrunePasses.push_back(DWARFRecordSectionSplitter(".eh_frame"));
Config.PrePrunePasses.push_back(EHFrameEdgeFixer( Config.PrePrunePasses.push_back(EHFrameEdgeFixer(
".eh_frame", 8, aarch64::Pointer32, aarch64::Pointer64, ".eh_frame", 8, aarch64::Pointer32, aarch64::Pointer64,
aarch64::Delta32, aarch64::Delta64, aarch64::NegDelta32)); aarch64::Delta32, aarch64::Delta64, aarch64::NegDelta32));
Config.PrePrunePasses.push_back(EHFrameNullTerminator(".eh_frame"));
// Add a mark-live pass. // Add a mark-live pass.
if (auto MarkLive = Ctx->getMarkLivePass(TT)) if (auto MarkLive = Ctx->getMarkLivePass(TT))
Config.PrePrunePasses.push_back(std::move(MarkLive)); Config.PrePrunePasses.push_back(std::move(MarkLive));
else else
Config.PrePrunePasses.push_back(markAllSymbolsLive); Config.PrePrunePasses.push_back(markAllSymbolsLive);
// Add an in-place GOT/TLS/Stubs build pass. // Add an in-place GOT/TLS/Stubs build pass.
Show All 11 Lines