This is an archive of the discontinued LLVM Phabricator instance.

Differential D145877

[flang][nfc] Avoid generating external-hello-world by default
ClosedPublic

Authored by sunshaoce on Mar 12 2023, 8:42 AM.

Details

Reviewers
awarzynski
klausler
clementval
sscalpone
luporl
Commits
rGcbd86cf2e89e: [flang][nfc] Avoid generating external-hello-world by default
Summary

The current setting is not working.
When compiling flang, the external-hello-world is still compiled by default.

Diff Detail

Event Timeline

sunshaoce created this revision.Mar 12 2023, 8:42 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 12 2023, 8:42 AM
sunshaoce requested review of this revision.Mar 12 2023, 8:42 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptMar 12 2023, 8:42 AM
Harbormaster completed remote builds in B218882: Diff 504443.Mar 12 2023, 8:58 AM
luporl added a subscriber: luporl.Mar 13 2023, 7:09 AM

Looks good to me.

flang/examples/CMakeLists.txt
2

This doesn't seem to be needed.

sunshaoce updated this revision to Diff 504660.Mar 13 2023, 7:53 AM
sunshaoce marked an inline comment as done.

Address @luporl's comment

luporl accepted this revision.Mar 13 2023, 8:08 AM
This revision is now accepted and ready to land.Mar 13 2023, 8:08 AM
This revision was landed with ongoing or failed builds.Mar 13 2023, 9:11 AM
Closed by commit rGcbd86cf2e89e: [flang][nfc] Avoid generating external-hello-world by default (authored by sunshaoce). · Explain Why
This revision was automatically updated to reflect the committed changes.
sunshaoce added a commit: rGcbd86cf2e89e: [flang][nfc] Avoid generating external-hello-world by default.
Harbormaster completed remote builds in B219045: Diff 504660.Mar 13 2023, 10:05 AM

Revision Contents

PathSize
flang/
examples/
12 lines
ExternalHelloWorld/
7 lines

Diff 504698

flang/examples/CMakeLists.txt

  • This file was copied to flang/examples/ExternalHelloWorld/CMakeLists.txt.
if(NOT FLANG_BUILD_EXAMPLES) if(NOT FLANG_BUILD_EXAMPLES)
set(EXCLUDE_FROM_ALL ON) set_property(DIRECTORY PROPERTY EXCLUDE_FROM_ALL ON)
luporlUnsubmitted
Done
ReplyInline Actions

This doesn't seem to be needed.

luporl: This doesn't seem to be needed.
endif() endif()
# This test is not run by default as it requires input. add_subdirectory(ExternalHelloWorld)
add_executable(external-hello-world
external-hello.cpp
)
target_link_libraries(external-hello-world
FortranRuntime
)
add_subdirectory(PrintFlangFunctionNames) add_subdirectory(PrintFlangFunctionNames)
add_subdirectory(FlangOmpReport) add_subdirectory(FlangOmpReport)

flang/examples/ExternalHelloWorld/CMakeLists.txt

  • This file was copied from flang/examples/CMakeLists.txt.
if(NOT FLANG_BUILD_EXAMPLES)
set(EXCLUDE_FROM_ALL ON)
endif()
# This test is not run by default as it requires input. # This test is not run by default as it requires input.
add_executable(external-hello-world add_executable(external-hello-world
external-hello.cpp external-hello.cpp
) )
target_link_libraries(external-hello-world target_link_libraries(external-hello-world
FortranRuntime FortranRuntime
) )
add_subdirectory(PrintFlangFunctionNames)
add_subdirectory(FlangOmpReport)

flang/examples/ExternalHelloWorld/external-hello.cpp

  • This file was moved from flang/examples/external-hello.cpp.
The contents of this file were not changed.

flang/examples/external-hello.cpp

  • This file was moved to flang/examples/ExternalHelloWorld/external-hello.cpp.