Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D145841

[clang][Interp] Fix diagnostics for calling non-constexpr constructors
ClosedPublic
Actions

Authored by tbaeder on Mar 11 2023, 12:58 AM.

Details

Reviewers
aaron.ballman
erichkeane
tahonermann
shafik
Commits
rG58cf70b2cdc1: [clang][Interp] Fix diagnostics for calling non-constexpr constructors

Diff Detail

Event Timeline

tbaeder created this revision.Mar 11 2023, 12:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2023, 12:58 AM
tbaeder requested review of this revision.Mar 11 2023, 12:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2023, 12:58 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B218814: Diff 504345.Mar 11 2023, 1:33 AM
tbaeder updated this revision to Diff 504406.Mar 11 2023, 10:28 PM
Harbormaster completed remote builds in B218858: Diff 504406.Mar 11 2023, 11:04 PM
tbaeder added a comment.Mar 19 2023, 12:27 AM

Ping

aaron.ballman accepted this revision.Mar 23 2023, 10:53 AM

LGTM

clang/test/AST/Interp/records.cpp
353–354
This revision is now accepted and ready to land.Mar 23 2023, 10:53 AM
tbaeder marked an inline comment as done.Mar 23 2023, 10:47 PM
Closed by commit rG58cf70b2cdc1: [clang][Interp] Fix diagnostics for calling non-constexpr constructors (authored by tbaeder). · Explain WhyApr 3 2023, 6:42 AM
This revision was automatically updated to reflect the committed changes.
tbaeder added a commit: rG58cf70b2cdc1: [clang][Interp] Fix diagnostics for calling non-constexpr constructors.

Revision Contents
Changeset List

PathSize
clang/
lib/
AST/
Interp/
2 lines
test/
AST/
Interp/
4 lines
15 lines

Diff 510485

View Options

clang/lib/AST/Interp/ByteCodeExprGen.cpp

Loading...
View Options

clang/test/AST/Interp/cxx20.cpp

Loading...
View Options

clang/test/AST/Interp/records.cpp

Loading...