This is an archive of the discontinued LLVM Phabricator instance.

Differential D145494

[compiler-rt][builtins] Define AT_HWCAP2 for AArch64
ClosedPublic

Authored by xry111 on Mar 7 2023, 5:33 AM.

Details

Reviewers
ilinpv
smeenai
nikic
Commits
rG23fcca822a3a: [compiler-rt][builtins] Define AT_HWCAP2 for AArch64
Summary

Without the definition, build fails on AArch64 with error: 'AT_HWCAP2' undeclared (first use in this function); did you mean 'AT_HWCAP'? with old Glibc versions.

Diff Detail

Event Timeline

xry111 created this revision.Mar 7 2023, 5:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2023, 5:33 AM
Herald added subscribers: Enna1, kristof.beyls, dberris. · View Herald Transcript
xry111 requested review of this revision.Mar 7 2023, 5:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2023, 5:33 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
xry111 edited the summary of this revision. (Show Details)Mar 7 2023, 5:36 AM
xry111 updated this revision to Diff 503007.Mar 7 2023, 5:38 AM
nikic added a subscriber: nikic.Mar 7 2023, 5:38 AM
nikic added inline comments.
compiler-rt/lib/builtins/cpu_model.c
927
xry111 marked an inline comment as done.Mar 7 2023, 5:41 AM
xry111 added inline comments.
compiler-rt/lib/builtins/cpu_model.c
927

Just corrected after a cup of coffee :). Too sleepy today.

glaubitz added a subscriber: glaubitz.Mar 7 2023, 5:43 AM
nikic accepted this revision.Mar 7 2023, 5:58 AM

LGTM

This revision is now accepted and ready to land.Mar 7 2023, 5:58 AM
Herald added a subscriber: StephenFan. · View Herald TranscriptMar 7 2023, 5:58 AM
ilinpv mentioned this in D127812: [AArch64] FMV support and necessary target features dependencies..Mar 7 2023, 6:20 AM
Harbormaster completed remote builds in B217855: Diff 503007.Mar 7 2023, 6:42 AM
nikic added a comment.Mar 8 2023, 7:06 AM

Do you have commit access, or do you need somebody to land this for you? If so, could you please share the Name <email> to use for the commit?

xry111 marked an inline comment as done.Mar 8 2023, 7:21 AM
In D145494#4178090, @nikic wrote:

Do you have commit access, or do you need somebody to land this for you? If so, could you please share the Name <email> to use for the commit?

I don't have commit access.

Xi Ruoyao <xry111@xry111.site>

Closed by commit rG23fcca822a3a: [compiler-rt][builtins] Define AT_HWCAP2 for AArch64 (authored by xry111, committed by nikic). · Explain WhyMar 8 2023, 7:28 AM
This revision was automatically updated to reflect the committed changes.
nikic added a commit: rG23fcca822a3a: [compiler-rt][builtins] Define AT_HWCAP2 for AArch64.

Revision Contents

PathSize
compiler-rt/
lib/
builtins/
3 lines

Diff 503361

compiler-rt/lib/builtins/cpu_model.c

Show First 20 Lines • Show All 918 Lines • ▼ Show 20 Lines
#endif #endif
#ifndef HWCAP_SSBS #ifndef HWCAP_SSBS
#define HWCAP_SSBS (1 << 28) #define HWCAP_SSBS (1 << 28)
#endif #endif
#ifndef HWCAP_SB #ifndef HWCAP_SB
#define HWCAP_SB (1 << 29) #define HWCAP_SB (1 << 29)
#endif #endif
#ifndef AT_HWCAP2
nikicUnsubmitted
Done
ReplyInline Actions
#endif
- #ifndef AT_HWCAP
+ #ifndef AT_HWCAP2
#define AT_HWCAP2 26
nikic:
xry111AuthorUnsubmitted
Done
ReplyInline Actions

Just corrected after a cup of coffee :). Too sleepy today.

xry111: Just corrected after a cup of coffee :). Too sleepy today.
#define AT_HWCAP2 26
#endif
#ifndef HWCAP2_DCPODP #ifndef HWCAP2_DCPODP
#define HWCAP2_DCPODP (1 << 0) #define HWCAP2_DCPODP (1 << 0)
#endif #endif
#ifndef HWCAP2_SVE2 #ifndef HWCAP2_SVE2
#define HWCAP2_SVE2 (1 << 1) #define HWCAP2_SVE2 (1 << 1)
#endif #endif
#ifndef HWCAP2_SVEAES #ifndef HWCAP2_SVEAES
#define HWCAP2_SVEAES (1 << 2) #define HWCAP2_SVEAES (1 << 2)
▲ Show 20 Lines • Show All 420 Lines • Show Last 20 Lines