[GlobalOpt] Collect initializer when building GlobalPart.
ClosedPublic
Actions

Authored by fhahn on Tue, Mar 7, 5:11 AM.

Details

Reviewers

aeubanks
nikic
kubamracek

Commits

rG84870c4abbac: [GlobalOpt] Collect initializer when building GlobalPart.

Summary

Update the code to collect the initializer when collecting the types for
a global, as suggested by @nikic in D144476.

This replaces code which bailed out if *any* part doesn't have an
initializer with a continue to just skip parts which don't have an
initializer.

Depends on D145489.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

fhahn created this revision.Tue, Mar 7, 5:11 AM

Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 7, 5:11 AM

Herald added subscribers: ormris, StephenFan, hiraditya. · View Herald Transcript

fhahn requested review of this revision.Tue, Mar 7, 5:11 AM

Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 7, 5:11 AM

fhahn mentioned this in D144476: [GlobalOpt] Extend logic in SRA heuristic to skip stores of initializer..Tue, Mar 7, 5:12 AM

nikic added inline comments.Tue, Mar 7, 6:13 AM

llvm/lib/Transforms/IPO/GlobalOpt.cpp
388–390	or so to only compute this once?

Harbormaster completed remote builds in B217847: Diff 502997.Tue, Mar 7, 6:57 AM

Only call ConstantFoldLoadFromConst when new entry has been inserted.

fhahn marked an inline comment as done.Wed, Mar 8, 3:42 AM

fhahn added inline comments.

llvm/lib/Transforms/IPO/GlobalOpt.cpp
388–390	Yeah that's better, updated!

Harbormaster completed remote builds in B218052: Diff 503303.Wed, Mar 8, 5:29 AM

nikic added inline comments.Wed, Mar 8, 8:45 AM

llvm/lib/Transforms/IPO/GlobalOpt.cpp
393	Can drop braces
580	Hm, if this happens, won't we leave behind references to a removed global? I think we need to make sure all initializers are known upfront, e.g. in the above offset checking loop.

fhahn mentioned this in rGa011823bff4d: [GlobalOpt] Add test where the initializer evaluation fails..Fri, Mar 10, 7:02 AM

Bail out if global initializer cannot be evaluated (test added in a011823bff4d5399).

Harbormaster completed remote builds in B218684: Diff 504147.Fri, Mar 10, 10:40 AM

Ping :)

LGTM

This revision is now accepted and ready to land.Fri, Mar 17, 6:29 AM

Closed by commit rG84870c4abbac: [GlobalOpt] Collect initializer when building GlobalPart. (authored by fhahn). · Explain WhySun, Mar 19, 1:54 PM

This revision was automatically updated to reflect the committed changes.

fhahn added a commit: rG84870c4abbac: [GlobalOpt] Collect initializer when building GlobalPart..

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Transforms/

IPO/

GlobalOpt.cpp

56 lines

Diff 506419

View Options

llvm/lib/Transforms/IPO/GlobalOpt.cpp

[GlobalOpt] Collect initializer when building GlobalPart.ClosedPublicActions