This is an archive of the discontinued LLVM Phabricator instance.

Differential D145434

[lld][ELF] Remove unused enum value. NFC
ClosedPublic

Authored by sbc100 on Mar 6 2023, 2:45 PM.

Details

Reviewers
MaskRay
Commits
rG088d1f100ebd: [lld][ELF] Remove unused enum value. NFC
Summary

The usage was removed in https://reviews.llvm.org/D119074

Diff Detail

Event Timeline

sbc100 created this revision.Mar 6 2023, 2:45 PM
Herald added a reviewer: MaskRay. · View Herald TranscriptMar 6 2023, 2:45 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: wingo, arichardson, emaste. · View Herald Transcript
sbc100 requested review of this revision.Mar 6 2023, 2:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 6 2023, 2:45 PM
Herald added subscribers: llvm-commits, aheejin. · View Herald Transcript
MaskRay accepted this revision.Mar 6 2023, 2:49 PM

Add NFC

This revision is now accepted and ready to land.Mar 6 2023, 2:49 PM
sbc100 retitled this revision from [lld][ELF] Remove unused enum value to [lld][ELF] Remove unused enum value. NFC.Mar 6 2023, 4:06 PM
This revision was landed with ongoing or failed builds.Mar 6 2023, 4:06 PM
Closed by commit rG088d1f100ebd: [lld][ELF] Remove unused enum value. NFC (authored by sbc100). · Explain Why
This revision was automatically updated to reflect the committed changes.
sbc100 added a commit: rG088d1f100ebd: [lld][ELF] Remove unused enum value. NFC.
Harbormaster completed remote builds in B217716: Diff 502816.Mar 6 2023, 7:23 PM

Revision Contents

PathSize
lld/
ELF/
1 line

Diff 502849

lld/ELF/InputFiles.h

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesprotected:
std::unique_ptr<Symbol *[]> symbols; std::unique_ptr<Symbol *[]> symbols;
uint32_t numSymbols = 0; uint32_t numSymbols = 0;
SmallVector<InputSectionBase *, 0> sections; SmallVector<InputSectionBase *, 0> sections;
public: public:
enum Kind : uint8_t { enum Kind : uint8_t {
ObjKind, ObjKind,
SharedKind, SharedKind,
ArchiveKind,
BitcodeKind, BitcodeKind,
BinaryKind, BinaryKind,
}; };
Kind kind() const { return fileKind; } Kind kind() const { return fileKind; }
bool isElf() const { bool isElf() const {
Kind k = kind(); Kind k = kind();
▲ Show 20 Lines • Show All 312 Lines • Show Last 20 Lines