[clang] Update test according to P1937

[Fznamznon]

Summary

https://wg21.link/p1937 proposes that in unevaluated contexts, consteval
functions should not be immediately evaluated.
Clang implemented p1937 a while ago, its behavior is correct and the
test needs an update.

[aaron.ballman]

LGTM, thank you for cleaning that test up!

[shafik]

Thank you for the fix.

Besides the nitpick, LGTM

clang/test/CXX/expr/expr.const/p8-2a.cpp

14

How about "Prior to P1937R2 consteval functions were evaluated even in otherwise unevaluated context, now this is well-formed"

and move it right above the "using check"

[Fznamznon]

Rebase and apply the nitpick

clang/test/CXX/expr/expr.const/p8-2a.cpp

14

Ok, sure.

clang/test/CXX/expr/expr.const/p8-2a.cpp

 // RUN: %clang_cc1 -std=c++20 -verify %s
 
 // expected-no-diagnostics
 
-namespace P1073R3 {
+namespace P1937R2 {
 struct N {
   constexpr N() {}
   N(N const&) = delete;
 };
 
 template<typename T> constexpr void bad_assert_copyable() { T t; T t2 = t; }
 using ineffective = decltype(bad_assert_copyable<N>());
 
-// bad_assert_copyable<N> is not needed for constant evaluation
-// (and thus not instantiated)
+// consteval assert is not instantiated as well.
 template<typename T> consteval void assert_copyable() { T t; T t2 = t; }
 using check = decltype(assert_copyable<N>());
-// FIXME: this should give an error because assert_copyable<N> is instantiated
-// (because it is needed for constant evaluation), but the attempt to copy t is
-// ill-formed.
-} // namespace P1073R3
+
+template<typename T>
+__add_rvalue_reference(T) declval();
+
+constexpr auto add1(auto lhs, auto rhs) {
+    return lhs + rhs;
+}
+using T = decltype(add1(declval<int>(), declval<int>()));
+
+consteval auto add2(auto lhs, auto rhs) {
+    return lhs + rhs;
+}
+using T = decltype(add2(declval<int>(), declval<int>()));
+} // namespace P1937R2