This is an archive of the discontinued LLVM Phabricator instance.

[test] Remove occurences of br undef in CodeGen/AArch64 tests
Needs ReviewPublic

Authored by kritgpt on Mar 5 2023, 2:36 PM.

Diff Detail

Event Timeline

kritgpt created this revision.Mar 5 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 2:36 PM
kritgpt requested review of this revision.Mar 5 2023, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 2:36 PM
fhahn added a subscriber: fhahn.Mar 6 2023, 2:04 AM

Not sure if replace_undef_X is an ideal name. Might be better to use something short like cX or condX

Not sure if replace_undef_X is an ideal name. Might be better to use something short like cX or condX

I went for this name to avoid clashes with any existing arguments. Wasn't sure if cX or condX are already used in any of the tests.

Groverkss added inline comments.
llvm/test/CodeGen/AArch64/arm64-bitfield-extract.ll
1005

This is why you are getting failed tests. % is not a valid variable name character for FileCheck.