Page MenuHomePhabricator

[clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header
ClosedPublic

Authored by mikecrowe on Sat, Mar 4, 1:07 PM.

Details

Summary

Remove duplication in abseil-redundant-strcat-calls check tests,
by using dummy <string> header file string.

Depends on D145310

Diff Detail

Event Timeline

mikecrowe created this revision.Sat, Mar 4, 1:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Mar 4, 1:07 PM
mikecrowe requested review of this revision.Sat, Mar 4, 1:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Mar 4, 1:07 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mikecrowe retitled this revision from Make abseil-redundant-strcat-calls checker use <string> header to [clang-tidy] Make abseil-redundant-strcat-calls checker use <string> header.
mikecrowe updated this revision to Diff 503884.Thu, Mar 9, 12:42 PM

Re-upload using arc.

PiotrZSL accepted this revision.Fri, Mar 10, 2:00 AM

It's fine, absl::StrCat returns std::string.
So those changes are correct.
Here you can find source code https://github.com/abseil/abseil-cpp/blob/master/absl/strings/str_cat.h

This revision is now accepted and ready to land.Fri, Mar 10, 2:00 AM

It's fine, absl::StrCat returns std::string.
So those changes are correct.

Thanks. Would you like me to remove the unnecessary noise from the commit message then, or will you do that as part of landing it?

PiotrZSL retitled this revision from [clang-tidy] Make abseil-redundant-strcat-calls checker use <string> header to [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header.Sat, Mar 11, 9:44 AM
PiotrZSL edited the summary of this revision. (Show Details)
PiotrZSL edited the summary of this revision. (Show Details)