Page MenuHomePhabricator
Differential D145311

[clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header
ClosedPublic
Actions

Authored by mikecrowe on Sat, Mar 4, 1:07 PM.

Details

Reviewers
carlosgalvezp
PiotrZSL
Commits
rG988355808efc: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header
Summary

Remove duplication in abseil-redundant-strcat-calls check tests,
by using dummy <string> header file string.

Depends on D145310

Diff Detail

Event Timeline

mikecrowe created this revision.Sat, Mar 4, 1:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Mar 4, 1:07 PM
mikecrowe requested review of this revision.Sat, Mar 4, 1:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Mar 4, 1:07 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mikecrowe added a child revision: D145312: [clang-tidy] Make readability-string-compare check use <string> header.Sat, Mar 4, 1:09 PM
mikecrowe retitled this revision from Make abseil-redundant-strcat-calls checker use <string> header to [clang-tidy] Make abseil-redundant-strcat-calls checker use <string> header.
Herald added a subscriber: xazax.hun. · View Herald TranscriptSat, Mar 4, 1:09 PM
mikecrowe mentioned this in D144216: [clang-tidy] Extract string header from redundant-string-cstr checker.Sat, Mar 4, 1:15 PM
Harbormaster completed remote builds in B217378: Diff 502387.Sat, Mar 4, 1:29 PM
mikecrowe updated this revision to Diff 503884.Thu, Mar 9, 12:42 PM

Re-upload using arc.

Herald added a subscriber: PiotrZSL. · View Herald TranscriptThu, Mar 9, 12:42 PM
mikecrowe added a child revision: D145724: [clang-tidy] Provide default template arguments in <string>.Thu, Mar 9, 12:50 PM
Harbormaster completed remote builds in B218478: Diff 503884.Thu, Mar 9, 2:10 PM
PiotrZSL accepted this revision.Fri, Mar 10, 2:00 AM

It's fine, absl::StrCat returns std::string.
So those changes are correct.
Here you can find source code https://github.com/abseil/abseil-cpp/blob/master/absl/strings/str_cat.h

This revision is now accepted and ready to land.Fri, Mar 10, 2:00 AM
mikecrowe added a comment.Sat, Mar 11, 9:34 AM
In D145311#4184159, @PiotrZSL wrote:

It's fine, absl::StrCat returns std::string.
So those changes are correct.

Thanks. Would you like me to remove the unnecessary noise from the commit message then, or will you do that as part of landing it?

PiotrZSL retitled this revision from [clang-tidy] Make abseil-redundant-strcat-calls checker use <string> header to [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header.Sat, Mar 11, 9:44 AM
PiotrZSL edited the summary of this revision. (Show Details)
PiotrZSL edited the summary of this revision. (Show Details)
Closed by commit rG988355808efc: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header (authored by mikecrowe, committed by PiotrZSL). · Explain WhySat, Mar 11, 9:49 AM
This revision was automatically updated to reflect the committed changes.
PiotrZSL added a commit: rG988355808efc: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header.

Revision Contents
Changeset List

PathSize
clang-tools-extra/
test/
clang-tidy/
checkers/
abseil/
128 lines

Diff 504383

View Options

clang-tools-extra/test/clang-tidy/checkers/abseil/redundant-strcat-calls.cpp

Loading...