Differential D145310

[clang-tidy] Make readability-container-data-pointer use <string> header
ClosedPublic
Actions

Authored by mikecrowe on Sat, Mar 4, 1:04 PM.

Details

Reviewers

carlosgalvezp

Commits

rGefda335bf5be: [clang-tidy] Make readability-container-data-pointer use <string> header

Summary

This requires operator[] to be added to the std::basic_string
implementation.

Depends on D144216

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mikecrowe created this revision.Sat, Mar 4, 1:04 PM

Herald added a project: Restricted Project. · View Herald TranscriptSat, Mar 4, 1:04 PM

Herald added a subscriber: xazax.hun. · View Herald Transcript

mikecrowe requested review of this revision.Sat, Mar 4, 1:04 PM

Herald added a project: Restricted Project. · View Herald TranscriptSat, Mar 4, 1:04 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B217377: Diff 502386.Sat, Mar 4, 1:05 PM

mikecrowe edited the summary of this revision. (Show Details)Sat, Mar 4, 1:05 PM

mikecrowe added a parent revision: D144216: [clang-tidy] Extract string header from redundant-string-cstr checker.

mikecrowe added a subscriber: carlosgalvezp.

mikecrowe added a child revision: D145311: [clang-tidy][NFC] Make abseil-redundant-strcat-calls checker use <string> header.Sat, Mar 4, 1:07 PM

mikecrowe mentioned this in D144216: [clang-tidy] Extract string header from redundant-string-cstr checker.Sat, Mar 4, 1:15 PM

carlosgalvezp added a reviewer: carlosgalvezp.Sun, Mar 5, 9:18 AM

LGTM, would you mind rebasing to get the pre-merge jobs green?

This revision is now accepted and ready to land.Sun, Mar 5, 9:29 AM

Rebase on top of fb7ef637a84652dbd3d973a1ba7db9470181b5aa (which is a
descendent of ae25e2f19decb94198301f0726ee613f945cc405 aka D144216, on
which this change relies.)

Herald added a subscriber: PiotrZSL. · View Herald TranscriptThu, Mar 9, 12:40 PM

Harbormaster completed remote builds in B218476: Diff 503882.Thu, Mar 9, 2:07 PM

Closed by commit rGefda335bf5be: [clang-tidy] Make readability-container-data-pointer use <string> header (authored by mikecrowe, committed by carlosgalvezp). · Explain WhySat, Mar 11, 6:00 AM

This revision was automatically updated to reflect the committed changes.

carlosgalvezp added a commit: rGefda335bf5be: [clang-tidy] Make readability-container-data-pointer use <string> header.

Revision Contents
Changeset List

Path

Size

clang-tools-extra/

test/

clang-tidy/

checkers/

Inputs/

Headers/

string

3 lines

readability/

container-data-pointer.cpp

19 lines

Diff 504354

View Options

clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/string