This is an archive of the discontinued LLVM Phabricator instance.

[mlir][IR] Hash result types in OperationFingerPrint
ClosedPublic

Authored by springerm on Mar 2 2023, 3:17 AM.

Details

Summary

Result types were not considered in OperationFingerPrint. This can lead to missing IR dumps when running with shouldPrintAfterOnlyOnChange and false positives in D144552.

Diff Detail

Event Timeline

springerm created this revision.Mar 2 2023, 3:17 AM
Herald added a project: Restricted Project. · View Herald Transcript
springerm requested review of this revision.Mar 2 2023, 3:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2023, 3:17 AM
mehdi_amini accepted this revision.Mar 3 2023, 5:58 AM

Nice finding!

This revision is now accepted and ready to land.Mar 3 2023, 5:58 AM
This revision was automatically updated to reflect the committed changes.