This is an archive of the discontinued LLVM Phabricator instance.

[mlir][nfc] Clean-up ConvertToDestinationStyle.cpp.
ClosedPublic

Authored by pifon2a on Mar 2 2023, 1:26 AM.

Diff Detail

Event Timeline

pifon2a created this revision.Mar 2 2023, 1:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2023, 1:26 AM
pifon2a requested review of this revision.Mar 2 2023, 1:26 AM
springerm accepted this revision.Mar 2 2023, 1:29 AM
This revision is now accepted and ready to land.Mar 2 2023, 1:29 AM
This revision was landed with ongoing or failed builds.Mar 2 2023, 1:32 AM
This revision was automatically updated to reflect the committed changes.
jreiffers added inline comments.Mar 2 2023, 1:52 AM
mlir/lib/Dialect/Linalg/Transforms/ConvertToDestinationStyle.cpp
371–376

I suppose it's not possible to change the argument order of the linalg function?

mlir/lib/Dialect/Linalg/Transforms/ConvertToDestinationStyle.cpp
371–376

All functional-stye APIs should follow:

fun(builder, optional_loc, rest)

to be consistent with all the builder APIs and existing transform APIs.

The matchAndRewrite APIs are a special flower follow a different convention:

matchAndRewrite(rest, PatternRewriter &rewriter)

This convention is only in Rewrite/Conversion matchAndRewrite