Test added in 7f5d130a428f but I unfortunately don't have the FreeBSD CI bot running yet to catch before commit.
Details
Details
- Reviewers
ldionne Mordante - Group Reviewers
Restricted Project - Commits
- rG5295fe4e98dc: [libc++][chrono] XFAIL hh_mm_ss formatter test on FreeBSD
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Event Timeline
Comment Actions
LGTM after the fixes, please make sure it passes our current CI.
libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp | ||
---|---|---|
8 | I also would prefer this line to be after // UNSUPPORTED: gcc-12. I like to have the "normal" constrains at the top and the special cases lower. |
libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp | ||
---|---|---|
8 | I guess one more block down, after msvc? // TODO FMT Evaluate gcc-12 status // UNSUPPORTED: gcc-12 // TODO FMT Investigate Windows issues. // UNSUPPORTED: msvc, target={{.+}}-windows-gnu |
libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp | ||
---|---|---|
8 | That's also fine, I mainly care that lines 10-12 are at the top. These are the lines show the libc++/Standard related constrains. |
I also would prefer this line to be after // UNSUPPORTED: gcc-12. I like to have the "normal" constrains at the top and the special cases lower.