[libc++][chrono] XFAIL hh_mm_ss formatter test on FreeBSD

[emaste]

Summary

Test added in 7f5d130a428f but I unfortunately don't have the FreeBSD CI bot running yet to catch before commit.

[Mordante]

LGTM after the fixes, please make sure it passes our current CI.

libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp

8

I also would prefer this line to be after // UNSUPPORTED: gcc-12. I like to have the "normal" constrains at the top and the special cases lower.

[emaste]

libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp

8

I guess one more block down, after msvc?

// TODO FMT Evaluate gcc-12 status
// UNSUPPORTED: gcc-12

// TODO FMT Investigate Windows issues.
// UNSUPPORTED: msvc, target={{.+}}-windows-gnu

[Mordante]

libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp

8

That's also fine, I mainly care that lines 10-12 are at the top. These are the lines show the libc++/Standard related constrains.

[Mordante]

Thanks LGTM!

libcxx/test/std/time/time.syn/formatter.hh_mm_ss.pass.cpp

 //===----------------------------------------------------------------------===//
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // UNSUPPORTED: c++03, c++11, c++14, c++17
 // UNSUPPORTED: no-localization
 // UNSUPPORTED: libcpp-has-no-incomplete-format
 
 // TODO FMT Evaluate gcc-12 status
 // UNSUPPORTED: gcc-12
 
 // TODO FMT Investigate Windows issues.
 // UNSUPPORTED: msvc, target={{.+}}-windows-gnu
 
+// XFAIL: LIBCXX-FREEBSD-FIXME
+
 // REQUIRES: locale.fr_FR.UTF-8
 // REQUIRES: locale.ja_JP.UTF-8
 
 // <chrono>
 
 // template<class Rep, class Period, class charT>
 //   struct formatter<chrono::hh_mm_ss<duration<Rep, Period>>, charT>;