Page MenuHomePhabricator

[libc++] Granularize <exception>
ClosedPublic

Authored by philnik on Mar 1 2023, 11:26 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rG43562287a816: [libc++] Granularize <exception>
Summary

This patch also updates the moved code to the new style (i.e. formatted, replaced marcos and typedefs)

Diff Detail

Unit TestsFailed

TimeTest
7,030 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/containers/sequences/vector::exception_safety_exceptions_disabled.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/containers/sequences/vector/exception_safety_exceptions_disabled.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fno-exceptions -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/containers/sequences/vector/Output/exception_safety_exceptions_disabled.pass.cpp.dir/t.tmp.exe
25,760 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/depr/depr_default_allocator::allocator_types.cxx2a.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/depr/depr.default.allocator/allocator_types.cxx2a.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/depr/depr.default.allocator/Output/allocator_types.cxx2a.pass.cpp.dir/t.tmp.exe
4,550 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/depr/depr_default_allocator/allocator_members::address.cxx2a.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/address.cxx2a.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/depr/depr.default.allocator/allocator.members/Output/address.cxx2a.pass.cpp.dir/t.tmp.exe
6,840 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/depr/depr_default_allocator/allocator_members::address.depr_in_cxx17.verify.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/address.depr_in_cxx17.verify.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS -fsyntax-only -Wno-error -Xclang -verify -Xclang -verify-ignore-unexpected=note -ferror-limit=0
17,580 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/depr/depr_default_allocator/allocator_members::allocate.cxx2a.pass.cpp
Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.cxx2a.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/depr/depr.default.allocator/allocator.members/Output/allocate.cxx2a.pass.cpp.dir/t.tmp.exe
View Full Test Results (18 Failed)

Event Timeline

philnik created this revision.Mar 1 2023, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 11:26 AM
philnik requested review of this revision.Mar 1 2023, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 11:26 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 501614.Mar 1 2023, 11:50 AM

Generate files

philnik updated this revision to Diff 501618.Mar 1 2023, 12:02 PM

Remove <exception> from the format ignorelist

ldionne accepted this revision.Mar 9 2023, 8:45 AM
ldionne added inline comments.
libcxx/include/__exception/exception.h
25

In all headers, please keep the comments about the non-versioned namespace being used on purpose.

This revision is now accepted and ready to land.Mar 9 2023, 8:45 AM
philnik updated this revision to Diff 504064.Mar 10 2023, 2:16 AM
philnik marked an inline comment as done.

Address comments

philnik updated this revision to Diff 504094.Mar 10 2023, 4:27 AM

Try to fix CI

philnik updated this revision to Diff 504137.Mar 10 2023, 7:12 AM

Try to fix CI

philnik updated this revision to Diff 504371.Mar 11 2023, 8:12 AM

Try to fix CI

This revision was landed with ongoing or failed builds.Mar 12 2023, 2:19 PM
This revision was automatically updated to reflect the committed changes.