Differential D145095

[libc++] Granularize <exception>
ClosedPublic
Actions

Authored by philnik on Mar 1 2023, 11:26 AM.

Tags

Subscribers

Details

Reviewers

ldionne
Mordante

Group Reviewers

Restricted Project

Commits

rG43562287a816: [libc++] Granularize <exception>

Summary

This patch also updates the moved code to the new style (i.e. formatted, replaced marcos and typedefs)

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	7,030 ms	libcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/containers/sequences/vector::exception_safety_exceptions_disabled.pass.cpp Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/containers/sequences/vector/exception_safety_exceptions_disabled.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fno-exceptions -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/containers/sequences/vector/Output/exception_safety_exceptions_disabled.pass.cpp.dir/t.tmp.exe
	25,760 ms	libcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/depr/depr_default_allocator::allocator_types.cxx2a.pass.cpp Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/depr/depr.default.allocator/allocator_types.cxx2a.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/depr/depr.default.allocator/Output/allocator_types.cxx2a.pass.cpp.dir/t.tmp.exe
	4,550 ms	libcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/depr/depr_default_allocator/allocator_members::address.cxx2a.pass.cpp Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/address.cxx2a.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/depr/depr.default.allocator/allocator.members/Output/address.cxx2a.pass.cpp.dir/t.tmp.exe
	6,840 ms	libcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/depr/depr_default_allocator/allocator_members::address.depr_in_cxx17.verify.cpp Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/address.depr_in_cxx17.verify.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS -fsyntax-only -Wno-error -Xclang -verify -Xclang -verify-ignore-unexpected=note -ferror-limit=0
	17,580 ms	libcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx/depr/depr_default_allocator/allocator_members::allocate.cxx2a.pass.cpp Script: -- : 'COMPILED WITH'; /usr/bin/clang++-17 /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.cxx2a.pass.cpp --target=x86_64-unknown-linux-gnu -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wunused-template -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS -lc++experimental -nostdlib++ -L /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -Wl,-rpath,/home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/lib -lc++ -pthread -o /home/libcxx-builder/.buildkite-agent/builds/3de54df57404-1/llvm-project/libcxx-ci/build/generic-modules/test/libcxx/depr/depr.default.allocator/allocator.members/Output/allocate.cxx2a.pass.cpp.dir/t.tmp.exe
		View Full Test Results (18 Failed)

Event Timeline

philnik created this revision.Mar 1 2023, 11:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 11:26 AM

philnik requested review of this revision.Mar 1 2023, 11:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 11:26 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Harbormaster completed remote builds in B216786: Diff 501601.Mar 1 2023, 11:35 AM

Generate files

Harbormaster completed remote builds in B216797: Diff 501614.Mar 1 2023, 11:56 AM

Remove <exception> from the format ignorelist

Herald added a subscriber: arichardson. · View Herald TranscriptMar 1 2023, 12:02 PM

Harbormaster completed remote builds in B216801: Diff 501618.Mar 1 2023, 12:28 PM

ldionne accepted this revision.Mar 9 2023, 8:45 AM

ldionne added inline comments.

libcxx/include/__exception/exception.h
25	In all headers, please keep the comments about the non-versioned namespace being used on purpose.

This revision is now accepted and ready to land.Mar 9 2023, 8:45 AM

Address comments

Harbormaster completed remote builds in B218622: Diff 504064.Mar 10 2023, 3:04 AM

Try to fix CI

Harbormaster completed remote builds in B218645: Diff 504094.Mar 10 2023, 5:21 AM

Try to fix CI

Harbormaster completed remote builds in B218673: Diff 504137.Mar 10 2023, 7:50 AM

Try to fix CI

Harbormaster completed remote builds in B218832: Diff 504371.Mar 11 2023, 8:36 AM

Next try

Harbormaster completed remote builds in B218847: Diff 504393.Mar 11 2023, 3:15 PM

Next try

Harbormaster completed remote builds in B218891: Diff 504453.Mar 12 2023, 11:48 AM

This revision was landed with ongoing or failed builds.Mar 12 2023, 2:19 PM

Closed by commit rG43562287a816: [libc++] Granularize <exception> (authored by philnik). · Explain Why

This revision was automatically updated to reflect the committed changes.

philnik added a commit: rG43562287a816: [libc++] Granularize <exception>.

hans mentioned this in D145919: [libc++] Add missing include in exception_ptr.h.Mar 13 2023, 3:46 AM

hans mentioned this in rGc341d5030503: [libc++] Add missing include in exception_ptr.h.Mar 13 2023, 7:22 AM

Revision Contents
Changeset List

Path

Size

libcxx/

include/

5 lines

__exception/

91 lines

exception_ptr.h

107 lines

nested_exception.h

108 lines

42 lines

22 lines

__format/

formatter_integral.h

1 line

__iterator/

common_iterator.h

1 line

__memory/

1 line

1 line

2 lines

2 lines

299 lines

1 line

module.modulemap.in

13 lines

1 line

1 line

2 lines

1 line

2 lines

1 line

1 line

test/

libcxx/

private_headers.verify.cpp

5 lines

transitive_includes/

1 line

utils/

data/

ignore_format.txt

1 line

Diff 504137

libcxx/include/CMakeLists.txt

Loading...

libcxx/include/__exception/exception.h

Loading...

libcxx/include/__exception/exception_ptr.h

Loading...

libcxx/include/__exception/nested_exception.h

Loading...

libcxx/include/__exception/operations.h

Loading...

libcxx/include/__exception/terminate.h

Loading...

libcxx/include/__format/formatter_integral.h

Loading...

libcxx/include/__iterator/common_iterator.h

Loading...

libcxx/include/__memory/shared_ptr.h

Loading...

libcxx/include/__tree

Loading...

libcxx/include/any

Loading...

libcxx/include/deque

Loading...

libcxx/include/exception

Loading...

libcxx/include/libcxx.imp

Loading...

libcxx/include/module.modulemap.in

Loading...

libcxx/include/optional

Loading...

libcxx/include/span

Loading...

libcxx/include/string

Loading...

libcxx/include/string_view

Loading...

libcxx/include/valarray

Loading...

libcxx/include/variant

Loading...

libcxx/include/vector

Loading...

libcxx/test/libcxx/private_headers.verify.cpp

Loading...

libcxx/test/libcxx/transitive_includes/cxx2b.csv

Loading...

libcxx/utils/data/ignore_format.txt

Loading...