Page MenuHomePhabricator

[libc++] Granularize <exception>
ClosedPublic

Authored by philnik on Mar 1 2023, 11:26 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rG43562287a816: [libc++] Granularize <exception>
Summary

This patch also updates the moved code to the new style (i.e. formatted, replaced marcos and typedefs)

Diff Detail

Unit TestsFailed

TimeTest
107,140 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx::modules_include.sh.cpp
Script: -- : 'RUN: at line 57'; echo "" > /home/libcxx-builder/.buildkite-agent/builds/ca3c54eb40f7-1/llvm-project/libcxx-ci/build/generic-cxx2b/test/libcxx/Output/modules_include.sh.cpp.dir/t.tmp.sh

Event Timeline

philnik created this revision.Mar 1 2023, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 11:26 AM
philnik requested review of this revision.Mar 1 2023, 11:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 11:26 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 501614.Mar 1 2023, 11:50 AM

Generate files

philnik updated this revision to Diff 501618.Mar 1 2023, 12:02 PM

Remove <exception> from the format ignorelist

ldionne accepted this revision.Mar 9 2023, 8:45 AM
ldionne added inline comments.
libcxx/include/__exception/exception.h
25

In all headers, please keep the comments about the non-versioned namespace being used on purpose.

This revision is now accepted and ready to land.Mar 9 2023, 8:45 AM
philnik updated this revision to Diff 504064.Mar 10 2023, 2:16 AM
philnik marked an inline comment as done.

Address comments

philnik updated this revision to Diff 504094.Mar 10 2023, 4:27 AM

Try to fix CI

philnik updated this revision to Diff 504137.Mar 10 2023, 7:12 AM

Try to fix CI

philnik updated this revision to Diff 504371.Mar 11 2023, 8:12 AM

Try to fix CI

This revision was landed with ongoing or failed builds.Mar 12 2023, 2:19 PM
This revision was automatically updated to reflect the committed changes.