Details

Reviewers

ldionne
Mordante

Group Reviewers

Restricted Project

Commits

rG43562287a816: [libc++] Granularize <exception>

Summary

This patch also updates the moved code to the new style (i.e. formatted, replaced marcos and typedefs)

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

philnik created this revision.Wed, Mar 1, 11:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 1, 11:26 AM

philnik requested review of this revision.Wed, Mar 1, 11:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 1, 11:26 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

Harbormaster completed remote builds in B216786: Diff 501601.Wed, Mar 1, 11:35 AM

Generate files

Harbormaster completed remote builds in B216797: Diff 501614.Wed, Mar 1, 11:56 AM

Remove <exception> from the format ignorelist

Herald added a subscriber: arichardson. · View Herald TranscriptWed, Mar 1, 12:02 PM

Harbormaster completed remote builds in B216801: Diff 501618.Wed, Mar 1, 12:28 PM

ldionne accepted this revision.Thu, Mar 9, 8:45 AM

ldionne added inline comments.

libcxx/include/__exception/exception.h
25	In all headers, please keep the comments about the non-versioned namespace being used on purpose.

This revision is now accepted and ready to land.Thu, Mar 9, 8:45 AM

Address comments

Harbormaster completed remote builds in B218622: Diff 504064.Fri, Mar 10, 3:04 AM

Try to fix CI

Harbormaster completed remote builds in B218645: Diff 504094.Fri, Mar 10, 5:21 AM

Try to fix CI

Harbormaster completed remote builds in B218673: Diff 504137.Fri, Mar 10, 7:50 AM

Try to fix CI

Harbormaster completed remote builds in B218832: Diff 504371.Sat, Mar 11, 8:36 AM

Next try

Harbormaster completed remote builds in B218847: Diff 504393.Sat, Mar 11, 3:15 PM

Next try

Harbormaster completed remote builds in B218891: Diff 504453.Sun, Mar 12, 11:48 AM

This revision was landed with ongoing or failed builds.Sun, Mar 12, 2:19 PM

Closed by commit rG43562287a816: [libc++] Granularize <exception> (authored by philnik). · Explain Why

This revision was automatically updated to reflect the committed changes.

philnik added a commit: rG43562287a816: [libc++] Granularize <exception>.

hans mentioned this in D145919: [libc++] Add missing include in exception_ptr.h.Mon, Mar 13, 3:46 AM

hans mentioned this in rGc341d5030503: [libc++] Add missing include in exception_ptr.h.Mon, Mar 13, 7:22 AM

D136765 [ASan][libcxx] Annotating std::vector with all allocators

·Reviewers: Restricted Project, Restricted Project, philnik, vitalybuka

Fri, Mar 24, 4:02 AM

Author: AdvenamTacet

[libc++] Granularize <exception>
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 504471

libcxx/include/CMakeLists.txt

libcxx/include/__exception/exception.h

libcxx/include/__exception/exception_ptr.h

libcxx/include/__exception/nested_exception.h

libcxx/include/__exception/operations.h

libcxx/include/__exception/terminate.h

libcxx/include/__format/formatter_integral.h

libcxx/include/__iterator/common_iterator.h

libcxx/include/__memory/allocator.h

libcxx/include/__memory/shared_ptr.h

libcxx/include/__tree

libcxx/include/any

libcxx/include/deque

libcxx/include/exception

libcxx/include/istream

libcxx/include/libcxx.imp

libcxx/include/module.modulemap.in

libcxx/include/optional

libcxx/include/ostream

libcxx/include/span

libcxx/include/string

libcxx/include/string_view

libcxx/include/valarray

libcxx/include/variant

libcxx/include/vector

libcxx/test/libcxx/private_headers.verify.cpp

libcxx/test/std/containers/sequences/array/contiguous.pass.cpp

libcxx/test/std/utilities/memory/allocator.uses/allocator.uses.trait/uses_allocator.pass.cpp

libcxx/utils/data/ignore_format.txt

[libc++] Granularize <exception>ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 504471

libcxx/include/CMakeLists.txt

libcxx/include/__exception/exception.h

libcxx/include/__exception/exception_ptr.h

libcxx/include/__exception/nested_exception.h

libcxx/include/__exception/operations.h

libcxx/include/__exception/terminate.h

libcxx/include/__format/formatter_integral.h

libcxx/include/__iterator/common_iterator.h

libcxx/include/__memory/allocator.h

libcxx/include/__memory/shared_ptr.h

libcxx/include/__tree

libcxx/include/any

libcxx/include/deque

libcxx/include/exception

libcxx/include/istream

libcxx/include/libcxx.imp

libcxx/include/module.modulemap.in

libcxx/include/optional

libcxx/include/ostream

libcxx/include/span

libcxx/include/string

libcxx/include/string_view

libcxx/include/valarray

libcxx/include/variant

libcxx/include/vector

libcxx/test/libcxx/private_headers.verify.cpp

libcxx/test/std/containers/sequences/array/contiguous.pass.cpp

libcxx/test/std/utilities/memory/allocator.uses/allocator.uses.trait/uses_allocator.pass.cpp

libcxx/utils/data/ignore_format.txt

[libc++] Granularize <exception>
ClosedPublic
Actions

Revision Contents
Changeset List