[flang] lower transpose intrinsic to hlfir.transpose operation

[tblah]

Summary

Depends on D144880

[jeanPerier]

Nits in the result type computation, looks good otherwise.

flang/lib/Lower/ConvertCall.cpp

1325

nit: arrayType simplify proof reading.

1332

/*polymorphic=*/false should be hlfir::Entity{operands[0]}.isPolymorphic();

You can test it with a polymorphic input adding --polymorphic-type to bbc.

Polymorphism support is ramping up in the current lowering, so HLFIR will have to be on par and beyond to switch.

[tblah]

Thanks for review

Changes:

• Rename array to arrayTy
• Set isPolymorphic correctly
• Add a test featuring transpose of a matrix polymorphic types

[clementval]

flang/test/Lower/HLFIR/transpose.f90

21

+1 thanks to add polymorphic tests!

[jeanPerier]

flang/test/Lower/HLFIR/transpose.f90

30

Thanks a lot for the update. The lit test failure is caused by the missing ? after the element type inside hlfir.expr to denote it is polymorphic: !hlfir.expr<2x1xnone?>

[tblah]

Fix broken test

[jeanPerier]

LGTM

flang/lib/Lower/ConvertCall.cpp

if (intrinsic.name == "matmul") {
     llvm::SmallVector<mlir::Value> operands = getOperandVector(loweredActuals);
     mlir::Type resultTy =
         computeResultType(operands[0], *callContext.resultType);
     hlfir::MatmulOp matmulOp = builder.create<hlfir::MatmulOp>(
         loc, resultTy, operands[0], operands[1]);
 
     return {hlfir::EntityWithAttributes{matmulOp.getResult()}};
   }
+  if (intrinsic.name == "transpose") {
+    llvm::SmallVector<mlir::Value> operands = getOperandVector(loweredActuals);
+    hlfir::ExprType::Shape resultShape;
+    mlir::Type normalisedResult =
+        hlfir::getFortranElementOrSequenceType(*callContext.resultType);
+    auto array = normalisedResult.cast<fir::SequenceType>();
+    llvm::ArrayRef<int64_t> arrayShape = array.getShape();
+    assert(arrayShape.size() == 2 && "arguments to transpose have a rank of 2");
+    mlir::Type elementType = array.getEleTy();
+    resultShape.push_back(arrayShape[0]);
+    resultShape.push_back(arrayShape[1]);
+    mlir::Type resultTy = hlfir::ExprType::get(
+        builder.getContext(), resultShape, elementType, /*polymorphic=*/false);
+    hlfir::TransposeOp transposeOp =
+        builder.create<hlfir::TransposeOp>(loc, resultTy, operands[0]);
+
+    return {hlfir::EntityWithAttributes{transposeOp.getResult()}};
+  }
 
   // TODO add hlfir operations for other transformational intrinsics here
 
   // fallback to calling the intrinsic via fir.call
   return genIntrinsicRefCore(loweredActuals, intrinsic, argLowering,
                              callContext);
 }
 

flang/test/Lower/HLFIR/transpose.f90

+! Test lowering of TRANSPOSE intrinsic to HLFIR
+! RUN: bbc -emit-fir -hlfir -o - %s 2>&1 | FileCheck %s
+
+subroutine transpose1(m, res)
+  integer :: m(1,2), res(2, 1)
+  res = TRANSPOSE(m)
+endsubroutine
+! CHECK-LABEL: func.func @_QPtranspose1
+! CHECK:           %[[M_ARG:.*]]: !fir.ref<!fir.array<1x2xi32>>
+! CHECK:           %[[RES_ARG:.*]]: !fir.ref<!fir.array<2x1xi32>>
+! CHECK-DAG:     %[[ARG:.*]]:2 = hlfir.declare %[[M_ARG]](%[[M_SHAPE:.*]]) {[[NAME:.*]]} : (!fir.ref<!fir.array<1x2xi32>>, !fir.shape<2>) -> (!fir.ref<!fir.array<1x2xi32>>, !fir.ref<!fir.array<1x2xi32>>)
+! CHECK-DAG:     %[[RES:.*]]:2 = hlfir.declare %[[RES_ARG]](%[[RES_SHAPE:.*]]) {[[NAME2:.*]]} : (!fir.ref<!fir.array<2x1xi32>>, !fir.shape<2>) -> (!fir.ref<!fir.array<2x1xi32>>, !fir.ref<!fir.array<2x1xi32>>)
+! CHECK:         %[[EXPR:.*]] = hlfir.transpose %[[ARG]]#0 : (!fir.ref<!fir.array<1x2xi32>>) -> !hlfir.expr<2x1xi32>
+! CHECK-NEXT:    hlfir.assign %[[EXPR]] to %[[RES]]#0
+! CHECK-NEXT:    hlfir.destroy %[[EXPR]]
+! CHECK-NEXT:    return
+! CHECK-NEXT:  }