Page MenuHomePhabricator
Differential D144784

[mlir][tosa] Add FFT2d operation
ClosedPublic
Actions

Authored by lhutton1 on Feb 25 2023, 4:34 AM.

Details

Reviewers
jpienaar
rsuderman
eric-k256
nicolasvasilache
Commits
rG312938864e67: [mlir][tosa] Add FFT2d operation
Summary

Adds the FFT2d TOSA operation and supporting
shape inference function.

Signed-off-by: Luke Hutton <luke.hutton@arm.com>

Diff Detail

Event Timeline

lhutton1 created this revision.Feb 25 2023, 4:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2023, 4:34 AM
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 26 others. · View Herald Transcript
lhutton1 requested review of this revision.Feb 25 2023, 4:34 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptFeb 25 2023, 4:35 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B215928: Diff 500416.Feb 25 2023, 5:37 AM
lhutton1 added a comment.Mar 13 2023, 5:03 AM

Friendly ping for review

Herald added a subscriber: mgehre-amd. · View Herald TranscriptMar 13 2023, 5:03 AM
lhutton1 edited reviewers, added: jpienaar, rsuderman; removed: nicolasvasilache.Mar 13 2023, 9:38 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 13 2023, 9:38 AM
rsuderman edited reviewers, added: eric-k256; removed: nicolasvasilache.Mar 13 2023, 3:37 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 13 2023, 3:37 PM
rsuderman added a comment.Mar 13 2023, 3:38 PM

It looks good to me, just adding Eric to double check the description looks correct.

eric-k256 accepted this revision.Mar 13 2023, 4:05 PM

Thanks for checking Rob. Yes, this looks good to me.

This revision is now accepted and ready to land.Mar 13 2023, 4:05 PM
rsuderman accepted this revision.Mar 14 2023, 11:39 AM
Closed by commit rG312938864e67: [mlir][tosa] Add FFT2d operation (authored by lhutton1, committed by Robert Suderman <suderman@google.com>). · Explain WhyMar 14 2023, 12:07 PM
This revision was automatically updated to reflect the committed changes.
Robert Suderman <suderman@google.com> added a commit: rG312938864e67: [mlir][tosa] Add FFT2d operation.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
Tosa/
IR/
30 lines
lib/
Dialect/
Tosa/
IR/
10 lines
test/
Dialect/
Tosa/
7 lines
18 lines

Diff 505209

View Options

mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td

Loading...
View Options

mlir/lib/Dialect/Tosa/IR/TosaOps.cpp

Loading...
View Options

mlir/test/Dialect/Tosa/ops.mlir

Loading...
View Options

mlir/test/Dialect/Tosa/tosa-infer-shapes.mlir

Loading...