Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
In https://reviews.llvm.org/D144741#4151050, I wasn't sure how much heavylifting "pretty much" was doing in "pretty much anything with PassManager in it in the current ocaml bindings will be removed." Is there anything I removed in here that should be kept?
A benefit of removing the PassManager binding code now would that there is less code to review for my patch converting the bindings for OCaml 5.
As a side note, I would recommend requesting commit access as described in https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access.
Thank you for the advice @nikoc, I will consider it. I'm worried that I'm not yet familiar enough with the LLVM collaboration process and may make mistakes. For example, I'm new to Arcanist and worried that I may do something wrong if I'm given permission to run arc land, a command that I've never run before. I also notice that sometimes, the CI for my revisions has a spurious build failure that seems related to my code; should I be worried about those?
On that note, I got an email that I am one of two people possibly responsible for a build failure: https://lab.llvm.org/buildbot/#/builders/178/builds/4032/steps/13/logs/FAIL__lit___shtest-define_py Did I cause this?
@alan Unless the build failure is obviously related to your patch, you can ignore it. If it turns out to be because of your patch after all, a buildbot owner will revert it or contact you. As you're working on the ocaml bindings, it should be relatively obvious which failures are due to your changes and which ones are unrelated/flaky.