Page MenuHomePhabricator
Differential D144610

[InstCombine] Add transforms for `(icmp upred (or X, Y), X)`
Needs ReviewPublic
Actions

Authored by goldstein.w.n on Feb 22 2023, 5:20 PM.

Details

Reviewers
nikic
spatel
majnemer
Summary

We can simplify ule/ugt -> eq/ne and we can remove the xor in some
cases of eq/ne.

icmp (X | Y) u<= X --> (X | Y) == X

icmp (X | Y) u> X --> (X | Y) != X

icmp (X | noundef Y) eq/ne X --> (X & noundef Y) eq/ne noundef Y

Diff Detail

Event Timeline

goldstein.w.n created this revision.Feb 22 2023, 5:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2023, 5:20 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
goldstein.w.n requested review of this revision.Feb 22 2023, 5:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2023, 5:20 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B215389: Diff 499680.Feb 22 2023, 5:22 PM
goldstein.w.n added a parent revision: D144609: [InstCombine] Add tests for transforming `(icmp (or X, Y), X)`; NFC.Feb 22 2023, 5:23 PM
goldstein.w.n added reviewers: nikic, spatel, majnemer.
Herald added a subscriber: StephenFan. · View Herald TranscriptFeb 22 2023, 5:23 PM
goldstein.w.n updated this revision to Diff 499937.Feb 23 2023, 11:46 AM

Rebase

Harbormaster completed remote builds in B215576: Diff 499937.Feb 23 2023, 1:30 PM
goldstein.w.n updated this revision to Diff 502286.Fri, Mar 3, 3:56 PM

Split into two patch + helper

goldstein.w.n added a child revision: D145281: [InstCombine] Add transforms for `(icmp spred (or X, Y), X)`.Fri, Mar 3, 3:58 PM
goldstein.w.n retitled this revision from [InstCombine] Add transforms for `(icmp (xor X, Y), X)` to [InstCombine] Add transforms for `(icmp upred (or X, Y), X)`.Fri, Mar 3, 4:01 PM
goldstein.w.n edited the summary of this revision. (Show Details)
goldstein.w.n updated this revision to Diff 502302.Fri, Mar 3, 4:07 PM
goldstein.w.n edited the summary of this revision. (Show Details)

Rebase

Harbormaster completed remote builds in B217310: Diff 502302.Fri, Mar 3, 6:31 PM
goldstein.w.n updated this revision to Diff 502462.Sun, Mar 5, 12:44 PM

Swap operands so op0 is always or for cleaner logic

Harbormaster completed remote builds in B217444: Diff 502462.Sun, Mar 5, 1:34 PM
goldstein.w.n updated this revision to Diff 502730.Mon, Mar 6, 10:53 AM

Rebase

goldstein.w.n updated this revision to Diff 502800.Mon, Mar 6, 2:16 PM

Fix typo

Harbormaster completed remote builds in B217702: Diff 502800.Mon, Mar 6, 7:09 PM

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
InstCombine/
37 lines
test/
Transforms/
InstCombine/
12 lines

Diff 502800

View Options

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

Loading...
View Options

llvm/test/Transforms/InstCombine/icmp-of-or-x.ll

Loading...