[clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

[MatzeB]

Summary

It seems newer grpc / protobuf versions renamed Status::error_message() and Status::error_code() to message()
and code() to prepare for replacement with absl::Status with the same names.

As far as I can tell the new names are already available in the grpc-1.36 version mentioned in the README file.

[MatzeB]

I need this change to fix compilation in our environment which uses grpc-1.42.0...

[kadircet]

thanks, indeed the protobuf version used by grpc-1.36.3 has these available, https://github.com/protocolbuffers/protobuf/blob/19fb89416f3fdc2d6668f3738f444885575285bc/src/google/protobuf/stubs/status.h.

if you don't mind me asking, are you deliberately building remote-index components? i.e. do you have an internal remote-index server/deployment ? Asking as it'd be great to know that we've adoption here, outside of ourselves.

OTOH, if you're not actually using it, this shouldn't be built unless -DCLANGD_ENABLE_REMOTE=1 is part of the build config, hence we might have a bug in the build configuration and I'd like to make sure it's fixed.

[kuganv]

if you don't mind me asking, are you deliberately building remote-index components? i.e. do you have an internal remote-index server/deployment ? Asking as it'd be great to know that we've adoption here, outside of ourselves.

OTOH, if you're not actually using it, this shouldn't be built unless -DCLANGD_ENABLE_REMOTE=1 is part of the build config, hence we might have a bug in the build configuration and I'd like to make sure it's fixed.

Thanks for looking into it. Yes, we use -DCLANGD_ENABLE_REMOTE=On and provide grpc path with -DGRPC_INSTALL_PATH.

[MatzeB]

Asking as it'd be great to know that we've adoption here, outside of ourselves.

I'm not involved in any of this myself. But @kuganv is :)

clang-tools-extra/clangd/index/remote/monitor/Monitor.cpp

int main(int argc, char *argv[]) {
   google::protobuf::util::JsonPrintOptions Options;
   Options.add_whitespace = true;
   Options.always_print_primitive_fields = true;
   Options.preserve_proto_field_names = true;
   const auto JsonStatus =
       google::protobuf::util::MessageToJsonString(Response, &Output, Options);
   if (!JsonStatus.ok()) {
     clang::clangd::elog("Can not convert response ({0}) to JSON ({1}): {2}\n",
-                        Response.DebugString(), JsonStatus.error_code(),
-                        JsonStatus.error_message().as_string());
+                        Response.DebugString(),
+                        static_cast<int>(JsonStatus.code()),
+                        JsonStatus.message().as_string());
     return -1;
   }
   llvm::outs() << Output;
 }