This is an archive of the discontinued LLVM Phabricator instance.

Differential D144593

fix check-bolt tests on arm64
ClosedPublic

Authored by sebpop on Feb 22 2023, 2:10 PM.

Details

Reviewers
ayermolo
yota9
rafauler
Amir
maksfb
Commits
rGc63c185e7298: [BOLT] fix tests on arm64
Summary

The two tests were failing on arm64-linux with:
BOLT-ERROR: invalid target 'x86-64'.

Diff Detail

Event Timeline

sebpop created this revision.Feb 22 2023, 2:10 PM
Herald added a reviewer: rafauler. · View Herald TranscriptFeb 22 2023, 2:10 PM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: pengfei, kristof.beyls. · View Herald Transcript
sebpop requested review of this revision.Feb 22 2023, 2:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2023, 2:10 PM
ayermolo added a comment.Feb 22 2023, 2:15 PM

Should they just be moved under X86 folder?

Harbormaster completed remote builds in B215363: Diff 499648.Feb 22 2023, 2:19 PM
sebpop updated this revision to Diff 499826.Feb 23 2023, 6:22 AM

Moved tests to X86/

Harbormaster completed remote builds in B215499: Diff 499826.Feb 23 2023, 6:29 AM
yota9 accepted this revision.Feb 23 2023, 6:36 AM

LGTM thanks

This revision is now accepted and ready to land.Feb 23 2023, 6:36 AM
Amir requested changes to this revision.Feb 23 2023, 10:50 AM

Did you build without LLVM_ENABLE_TARGETS=X86? The test passes on aarch64 buildbot running here: https://lab.llvm.org/buildbot/#/builders/221/builds/10483
Let's keep these tests in common folder and add a proper requires statement.

This revision now requires changes to proceed.Feb 23 2023, 10:50 AM
Amir accepted this revision.Feb 23 2023, 10:54 AM

Nevermind, bolt/test/X86/lit.local.cfg actually has the required check.

This revision is now accepted and ready to land.Feb 23 2023, 10:54 AM
maksfb accepted this revision.Feb 23 2023, 1:31 PM

Thanks for the fix! Nit: please add "[BOLT]" to the title before committing.

Closed by commit rGc63c185e7298: [BOLT] fix tests on arm64 (authored by Sebastian Pop <spop@amazon.com>). · Explain WhyFeb 25 2023, 8:48 AM
This revision was automatically updated to reflect the committed changes.
Sebastian Pop <spop@amazon.com> added a commit: rGc63c185e7298: [BOLT] fix tests on arm64.

Revision Contents

Diff 500436

bolt/test/X86/pseudoprobe-decoding-inline.test

  • This file was moved from bolt/test/pseudoprobe-decoding-inline.test.
# REQUIRES: system-linux # REQUIRES: system-linux
# RUN: llvm-bolt %S/../../llvm/test/tools/llvm-profgen/Inputs/inline-cs-pseudoprobe.perfbin --print-pseudo-probes=all -o %t.bolt 2>&1 | FileCheck %s # RUN: llvm-bolt %S/../../../llvm/test/tools/llvm-profgen/Inputs/inline-cs-pseudoprobe.perfbin --print-pseudo-probes=all -o %t.bolt 2>&1 | FileCheck %s
CHECK: Report of decoding input pseudo probe binaries CHECK: Report of decoding input pseudo probe binaries
CHECK-NEXT: Pseudo Probe Desc: CHECK-NEXT: Pseudo Probe Desc:
CHECK-NEXT: GUID: 6699318081062747564 Name: foo CHECK-NEXT: GUID: 6699318081062747564 Name: foo
CHECK-NEXT: Hash: 563088904013236 CHECK-NEXT: Hash: 563088904013236
CHECK-NEXT: GUID: 15822663052811949562 Name: main CHECK-NEXT: GUID: 15822663052811949562 Name: main
CHECK-NEXT: Hash: 281479271677951 CHECK-NEXT: Hash: 281479271677951
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines

bolt/test/X86/pseudoprobe-decoding-noinline.test

  • This file was moved from bolt/test/pseudoprobe-decoding-noinline.test.
# REQUIRES: system-linux # REQUIRES: system-linux
# RUN: llvm-bolt %S/../../llvm/test/tools/llvm-profgen/Inputs/noinline-cs-pseudoprobe.perfbin --print-pseudo-probes=all -o %t.bolt 2>&1 | FileCheck %s # RUN: llvm-bolt %S/../../../llvm/test/tools/llvm-profgen/Inputs/noinline-cs-pseudoprobe.perfbin --print-pseudo-probes=all -o %t.bolt 2>&1 | FileCheck %s
;; Report of decoding input pseudo probe binaries ;; Report of decoding input pseudo probe binaries
; CHECK: GUID: 6699318081062747564 Name: foo ; CHECK: GUID: 6699318081062747564 Name: foo
; CHECK: Hash: 563088904013236 ; CHECK: Hash: 563088904013236
; CHECK: GUID: 15822663052811949562 Name: main ; CHECK: GUID: 15822663052811949562 Name: main
; CHECK: Hash: 281479271677951 ; CHECK: Hash: 281479271677951
; CHECK: GUID: 16434608426314478903 Name: bar ; CHECK: GUID: 16434608426314478903 Name: bar
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines

bolt/test/pseudoprobe-decoding-inline.test

  • This file was moved to bolt/test/X86/pseudoprobe-decoding-inline.test.

bolt/test/pseudoprobe-decoding-noinline.test

  • This file was moved to bolt/test/X86/pseudoprobe-decoding-noinline.test.