This is an archive of the discontinued LLVM Phabricator instance.

[Test] Invoke GetErrcMessages from config-ix instead of llvm/CMakeLists
ClosedPublic

Authored by bogner on Feb 21 2023, 3:44 PM.

Details

Summary

Since GetErrcMessages uses cmake's try_run mechanism it's sensitive
to changes to CMAKE_CXX_FLAGS, so we move it into config-ix with the
similar flag-sensitive configuration. This makes it run before
HandleLLVMOptions and avoids issues with LLVM_ENABLE_WERROR and other
configuration that manipulate CMAKE_CXX_FLAGS.

Diff Detail

Event Timeline

bogner created this revision.Feb 21 2023, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 3:44 PM
Herald added a subscriber: mcrosier. · View Herald Transcript
bogner requested review of this revision.Feb 21 2023, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 3:44 PM
beanz accepted this revision.Feb 21 2023, 3:57 PM

LGTM

This revision is now accepted and ready to land.Feb 21 2023, 3:57 PM
This revision was landed with ongoing or failed builds.Feb 21 2023, 4:07 PM
This revision was automatically updated to reflect the committed changes.