This is an archive of the discontinued LLVM Phabricator instance.

Differential D144236

[mlir][sparse] comment out test cases in sparse_conversion with similiar behavior.
ClosedPublic

Authored by Peiming on Feb 16 2023, 5:08 PM.

Details

Reviewers
aartbik
nicolasvasilache
wrengr
bixia
Commits
rGe6758c81f867: [mlir][sparse] comment out test cases in sparse_conversion with similiar…

Diff Detail

Event Timeline

Peiming created this revision.Feb 16 2023, 5:08 PM
Herald added a reviewer: aartbik. · View Herald TranscriptFeb 16 2023, 5:08 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hanchung, jsetoain, Moerafaat and 23 others. · View Herald Transcript
Peiming requested review of this revision.Feb 16 2023, 5:08 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptFeb 16 2023, 5:08 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Peiming updated this revision to Diff 498196.Feb 16 2023, 5:08 PM

revert unintended change

Peiming updated this revision to Diff 498197.Feb 16 2023, 5:09 PM

fix indent

Peiming added reviewers: wrengr, bixia.Feb 16 2023, 5:10 PM
aartbik accepted this revision.Feb 16 2023, 5:11 PM
aartbik added inline comments.
mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conversion_sparse2dense.mlir
137

pathes -> paths

186–187

add, was COUNT-28 before this so we remember that is the right value too ;-)

This revision is now accepted and ready to land.Feb 16 2023, 5:11 PM
Peiming updated this revision to Diff 498200.Feb 16 2023, 5:14 PM

address comments.

This revision was landed with ongoing or failed builds.Feb 16 2023, 5:15 PM
Closed by commit rGe6758c81f867: [mlir][sparse] comment out test cases in sparse_conversion with similiar… (authored by Peiming). · Explain Why
This revision was automatically updated to reflect the committed changes.
Peiming added a commit: rGe6758c81f867: [mlir][sparse] comment out test cases in sparse_conversion with similiar….
Harbormaster completed remote builds in B214300: Diff 498200.Feb 16 2023, 6:08 PM

Revision Contents

PathSize
mlir/
test/
Integration/
Dialect/
SparseTensor/
CPU/
108 lines

Diff 498202

mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conversion_sparse2dense.mlir

Show First 20 Lines • Show All 126 Lines • ▼ Show 20 Lines func.func @entry() {
// //
%s2341 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor1> %s2341 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor1>
%s2342 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor2> %s2342 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor2>
%s2343 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor3> %s2343 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor3>
%s2344 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor4> %s2344 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor4>
%s2345 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor5> %s2345 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor5>
%s2346 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor6> %s2346 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x4xf64, #Tensor6>
// NOTE: We commented out most cases with the dynamic-sized output tensor because finishing
// all of them are currently taking too long, and they are not covering too many new code
// paths.
aartbikUnsubmitted
Not Done
ReplyInline Actions

pathes -> paths

aartbik: pathes -> paths
%sp344 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<?x3x4xf64, #Tensor4> %sp344 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<?x3x4xf64, #Tensor4>
%sp345 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<?x3x4xf64, #Tensor5> // %sp345 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<?x3x4xf64, #Tensor5>
%sp346 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<?x3x4xf64, #Tensor6> // %sp346 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<?x3x4xf64, #Tensor6>
%s2p44 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x4xf64, #Tensor4> // %s2p44 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x4xf64, #Tensor4>
%s2p45 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x4xf64, #Tensor5> %s2p45 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x4xf64, #Tensor5>
%s2p46 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x4xf64, #Tensor6> // %s2p46 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x4xf64, #Tensor6>
%s23p4 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x?xf64, #Tensor4> // %s23p4 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x?xf64, #Tensor4>
%s23p5 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x?xf64, #Tensor5> // %s23p5 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x?xf64, #Tensor5>
%s23p6 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x?xf64, #Tensor6> %s23p6 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x3x?xf64, #Tensor6>
%s2pp4 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x?xf64, #Tensor4> // %s2pp4 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x?xf64, #Tensor4>
%s2pp5 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x?xf64, #Tensor5> // %s2pp5 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x?xf64, #Tensor5>
%s2pp6 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x?xf64, #Tensor6> // %s2pp6 = sparse_tensor.convert %src : tensor<2x3x4xf64> to tensor<2x?x?xf64, #Tensor6>
// //
// Convert sparse tensor back to dense. // Convert sparse tensor back to dense.
// //
%d2341 = sparse_tensor.convert %s2341 : tensor<2x3x4xf64, #Tensor1> to tensor<2x3x4xf64> %d2341 = sparse_tensor.convert %s2341 : tensor<2x3x4xf64, #Tensor1> to tensor<2x3x4xf64>
%d2342 = sparse_tensor.convert %s2342 : tensor<2x3x4xf64, #Tensor2> to tensor<2x3x4xf64> %d2342 = sparse_tensor.convert %s2342 : tensor<2x3x4xf64, #Tensor2> to tensor<2x3x4xf64>
%d2343 = sparse_tensor.convert %s2343 : tensor<2x3x4xf64, #Tensor3> to tensor<2x3x4xf64> %d2343 = sparse_tensor.convert %s2343 : tensor<2x3x4xf64, #Tensor3> to tensor<2x3x4xf64>
%d2344 = sparse_tensor.convert %s2344 : tensor<2x3x4xf64, #Tensor4> to tensor<2x3x4xf64> %d2344 = sparse_tensor.convert %s2344 : tensor<2x3x4xf64, #Tensor4> to tensor<2x3x4xf64>
%d2345 = sparse_tensor.convert %s2345 : tensor<2x3x4xf64, #Tensor5> to tensor<2x3x4xf64> %d2345 = sparse_tensor.convert %s2345 : tensor<2x3x4xf64, #Tensor5> to tensor<2x3x4xf64>
%d2346 = sparse_tensor.convert %s2346 : tensor<2x3x4xf64, #Tensor6> to tensor<2x3x4xf64> %d2346 = sparse_tensor.convert %s2346 : tensor<2x3x4xf64, #Tensor6> to tensor<2x3x4xf64>
%dp344 = sparse_tensor.convert %sp344 : tensor<?x3x4xf64, #Tensor4> to tensor<?x3x4xf64> %dp344 = sparse_tensor.convert %sp344 : tensor<?x3x4xf64, #Tensor4> to tensor<?x3x4xf64>
%dp345 = sparse_tensor.convert %sp345 : tensor<?x3x4xf64, #Tensor5> to tensor<?x3x4xf64> // %dp345 = sparse_tensor.convert %sp345 : tensor<?x3x4xf64, #Tensor5> to tensor<?x3x4xf64>
%dp346 = sparse_tensor.convert %sp346 : tensor<?x3x4xf64, #Tensor6> to tensor<?x3x4xf64> // %dp346 = sparse_tensor.convert %sp346 : tensor<?x3x4xf64, #Tensor6> to tensor<?x3x4xf64>
%d2p44 = sparse_tensor.convert %s2p44 : tensor<2x?x4xf64, #Tensor4> to tensor<2x?x4xf64> // %d2p44 = sparse_tensor.convert %s2p44 : tensor<2x?x4xf64, #Tensor4> to tensor<2x?x4xf64>
%d2p45 = sparse_tensor.convert %s2p45 : tensor<2x?x4xf64, #Tensor5> to tensor<2x?x4xf64> %d2p45 = sparse_tensor.convert %s2p45 : tensor<2x?x4xf64, #Tensor5> to tensor<2x?x4xf64>
%d2p46 = sparse_tensor.convert %s2p46 : tensor<2x?x4xf64, #Tensor6> to tensor<2x?x4xf64> // %d2p46 = sparse_tensor.convert %s2p46 : tensor<2x?x4xf64, #Tensor6> to tensor<2x?x4xf64>
%d23p4 = sparse_tensor.convert %s23p4 : tensor<2x3x?xf64, #Tensor4> to tensor<2x3x?xf64> // %d23p4 = sparse_tensor.convert %s23p4 : tensor<2x3x?xf64, #Tensor4> to tensor<2x3x?xf64>
%d23p5 = sparse_tensor.convert %s23p5 : tensor<2x3x?xf64, #Tensor5> to tensor<2x3x?xf64> // %d23p5 = sparse_tensor.convert %s23p5 : tensor<2x3x?xf64, #Tensor5> to tensor<2x3x?xf64>
%d23p6 = sparse_tensor.convert %s23p6 : tensor<2x3x?xf64, #Tensor6> to tensor<2x3x?xf64> %d23p6 = sparse_tensor.convert %s23p6 : tensor<2x3x?xf64, #Tensor6> to tensor<2x3x?xf64>
%d2pp4 = sparse_tensor.convert %s2pp4 : tensor<2x?x?xf64, #Tensor4> to tensor<2x?x?xf64> // %d2pp4 = sparse_tensor.convert %s2pp4 : tensor<2x?x?xf64, #Tensor4> to tensor<2x?x?xf64>
%d2pp5 = sparse_tensor.convert %s2pp5 : tensor<2x?x?xf64, #Tensor5> to tensor<2x?x?xf64> // %d2pp5 = sparse_tensor.convert %s2pp5 : tensor<2x?x?xf64, #Tensor5> to tensor<2x?x?xf64>
%d2pp6 = sparse_tensor.convert %s2pp6 : tensor<2x?x?xf64, #Tensor6> to tensor<2x?x?xf64> // %d2pp6 = sparse_tensor.convert %s2pp6 : tensor<2x?x?xf64, #Tensor6> to tensor<2x?x?xf64>
%dp3p4 = sparse_tensor.convert %sp344 : tensor<?x3x4xf64, #Tensor4> to tensor<?x3x?xf64> %dp3p4 = sparse_tensor.convert %sp344 : tensor<?x3x4xf64, #Tensor4> to tensor<?x3x?xf64>
%dp3p5 = sparse_tensor.convert %sp345 : tensor<?x3x4xf64, #Tensor5> to tensor<?x3x?xf64> // %dp3p5 = sparse_tensor.convert %sp345 : tensor<?x3x4xf64, #Tensor5> to tensor<?x3x?xf64>
%dp3p6 = sparse_tensor.convert %sp346 : tensor<?x3x4xf64, #Tensor6> to tensor<?x3x?xf64> // %dp3p6 = sparse_tensor.convert %sp346 : tensor<?x3x4xf64, #Tensor6> to tensor<?x3x?xf64>
%dpp44 = sparse_tensor.convert %s2p44 : tensor<2x?x4xf64, #Tensor4> to tensor<?x?x4xf64> // %dpp44 = sparse_tensor.convert %s2p44 : tensor<2x?x4xf64, #Tensor4> to tensor<?x?x4xf64>
%dpp45 = sparse_tensor.convert %s2p45 : tensor<2x?x4xf64, #Tensor5> to tensor<?x?x4xf64> %dpp45 = sparse_tensor.convert %s2p45 : tensor<2x?x4xf64, #Tensor5> to tensor<?x?x4xf64>
%dpp46 = sparse_tensor.convert %s2p46 : tensor<2x?x4xf64, #Tensor6> to tensor<?x?x4xf64> // %dpp46 = sparse_tensor.convert %s2p46 : tensor<2x?x4xf64, #Tensor6> to tensor<?x?x4xf64>
%dppp4 = sparse_tensor.convert %s2pp4 : tensor<2x?x?xf64, #Tensor4> to tensor<?x?x?xf64> // %dppp4 = sparse_tensor.convert %s2pp4 : tensor<2x?x?xf64, #Tensor4> to tensor<?x?x?xf64>
%dppp5 = sparse_tensor.convert %s2pp5 : tensor<2x?x?xf64, #Tensor5> to tensor<?x?x?xf64> // %dppp5 = sparse_tensor.convert %s2pp5 : tensor<2x?x?xf64, #Tensor5> to tensor<?x?x?xf64>
%dppp6 = sparse_tensor.convert %s2pp6 : tensor<2x?x?xf64, #Tensor6> to tensor<?x?x?xf64> // %dppp6 = sparse_tensor.convert %s2pp6 : tensor<2x?x?xf64, #Tensor6> to tensor<?x?x?xf64>
// //
// Check round-trip equality. And release dense tensors. // Check round-trip equality. And release dense tensors.
// // CHECK-COUNT-12: ( ( ( 1, 2, 3, 4 ), ( 5, 6, 7, 8 ), ( 9, 10, 11, 12 ) ), ( ( 13, 14, 15, 16 ), ( 17, 18, 19, 20 ), ( 21, 22, 23, 24 ) ) )
// CHECK-COUNT-28: ( ( ( 1, 2, 3, 4 ), ( 5, 6, 7, 8 ), ( 9, 10, 11, 12 ) ), ( ( 13, 14, 15, 16 ), ( 17, 18, 19, 20 ), ( 21, 22, 23, 24 ) ) ) // was COUNT-28 before.
aartbikUnsubmitted
Not Done
ReplyInline Actions

add, was COUNT-28 before this so we remember that is the right value too ;-)

aartbik: add, was COUNT-28 before this so we remember that is the right value too ;-)
call @dump_234(%src) : (tensor<2x3x4xf64>) -> () call @dump_234(%src) : (tensor<2x3x4xf64>) -> ()
call @dump_234(%d2341) : (tensor<2x3x4xf64>) -> () call @dump_234(%d2341) : (tensor<2x3x4xf64>) -> ()
call @dump_234(%d2342) : (tensor<2x3x4xf64>) -> () call @dump_234(%d2342) : (tensor<2x3x4xf64>) -> ()
call @dump_234(%d2343) : (tensor<2x3x4xf64>) -> () call @dump_234(%d2343) : (tensor<2x3x4xf64>) -> ()
call @dump_234(%d2344) : (tensor<2x3x4xf64>) -> () call @dump_234(%d2344) : (tensor<2x3x4xf64>) -> ()
call @dump_234(%d2345) : (tensor<2x3x4xf64>) -> () call @dump_234(%d2345) : (tensor<2x3x4xf64>) -> ()
call @dump_234(%d2346) : (tensor<2x3x4xf64>) -> () call @dump_234(%d2346) : (tensor<2x3x4xf64>) -> ()
call @dump_p34(%dp344) : (tensor<?x3x4xf64>) -> () call @dump_p34(%dp344) : (tensor<?x3x4xf64>) -> ()
call @dump_p34(%dp345) : (tensor<?x3x4xf64>) -> () // call @dump_p34(%dp345) : (tensor<?x3x4xf64>) -> ()
call @dump_p34(%dp346) : (tensor<?x3x4xf64>) -> () // call @dump_p34(%dp346) : (tensor<?x3x4xf64>) -> ()
call @dump_2p4(%d2p44) : (tensor<2x?x4xf64>) -> () // call @dump_2p4(%d2p44) : (tensor<2x?x4xf64>) -> ()
call @dump_2p4(%d2p45) : (tensor<2x?x4xf64>) -> () call @dump_2p4(%d2p45) : (tensor<2x?x4xf64>) -> ()
call @dump_2p4(%d2p46) : (tensor<2x?x4xf64>) -> () // call @dump_2p4(%d2p46) : (tensor<2x?x4xf64>) -> ()
call @dump_23p(%d23p4) : (tensor<2x3x?xf64>) -> () // call @dump_23p(%d23p4) : (tensor<2x3x?xf64>) -> ()
call @dump_23p(%d23p5) : (tensor<2x3x?xf64>) -> () // call @dump_23p(%d23p5) : (tensor<2x3x?xf64>) -> ()
call @dump_23p(%d23p6) : (tensor<2x3x?xf64>) -> () call @dump_23p(%d23p6) : (tensor<2x3x?xf64>) -> ()
call @dump_2pp(%d2pp4) : (tensor<2x?x?xf64>) -> () // call @dump_2pp(%d2pp4) : (tensor<2x?x?xf64>) -> ()
call @dump_2pp(%d2pp5) : (tensor<2x?x?xf64>) -> () // call @dump_2pp(%d2pp5) : (tensor<2x?x?xf64>) -> ()
call @dump_2pp(%d2pp6) : (tensor<2x?x?xf64>) -> () // call @dump_2pp(%d2pp6) : (tensor<2x?x?xf64>) -> ()
call @dump_p3p(%dp3p4) : (tensor<?x3x?xf64>) -> () call @dump_p3p(%dp3p4) : (tensor<?x3x?xf64>) -> ()
call @dump_p3p(%dp3p5) : (tensor<?x3x?xf64>) -> () // call @dump_p3p(%dp3p5) : (tensor<?x3x?xf64>) -> ()
call @dump_p3p(%dp3p6) : (tensor<?x3x?xf64>) -> () // call @dump_p3p(%dp3p6) : (tensor<?x3x?xf64>) -> ()
call @dump_pp4(%dpp44) : (tensor<?x?x4xf64>) -> () // call @dump_pp4(%dpp44) : (tensor<?x?x4xf64>) -> ()
call @dump_pp4(%dpp45) : (tensor<?x?x4xf64>) -> () call @dump_pp4(%dpp45) : (tensor<?x?x4xf64>) -> ()
call @dump_pp4(%dpp46) : (tensor<?x?x4xf64>) -> () // call @dump_pp4(%dpp46) : (tensor<?x?x4xf64>) -> ()
call @dump_ppp(%dppp4) : (tensor<?x?x?xf64>) -> () // call @dump_ppp(%dppp4) : (tensor<?x?x?xf64>) -> ()
call @dump_ppp(%dppp5) : (tensor<?x?x?xf64>) -> () // call @dump_ppp(%dppp5) : (tensor<?x?x?xf64>) -> ()
call @dump_ppp(%dppp6) : (tensor<?x?x?xf64>) -> () // call @dump_ppp(%dppp6) : (tensor<?x?x?xf64>) -> ()
// //
// Release sparse tensors. // Release sparse tensors.
// //
bufferization.dealloc_tensor %s2341 : tensor<2x3x4xf64, #Tensor1> bufferization.dealloc_tensor %s2341 : tensor<2x3x4xf64, #Tensor1>
bufferization.dealloc_tensor %s2342 : tensor<2x3x4xf64, #Tensor2> bufferization.dealloc_tensor %s2342 : tensor<2x3x4xf64, #Tensor2>
bufferization.dealloc_tensor %s2343 : tensor<2x3x4xf64, #Tensor3> bufferization.dealloc_tensor %s2343 : tensor<2x3x4xf64, #Tensor3>
bufferization.dealloc_tensor %s2344 : tensor<2x3x4xf64, #Tensor4> bufferization.dealloc_tensor %s2344 : tensor<2x3x4xf64, #Tensor4>
bufferization.dealloc_tensor %s2345 : tensor<2x3x4xf64, #Tensor5> bufferization.dealloc_tensor %s2345 : tensor<2x3x4xf64, #Tensor5>
bufferization.dealloc_tensor %s2346 : tensor<2x3x4xf64, #Tensor6> bufferization.dealloc_tensor %s2346 : tensor<2x3x4xf64, #Tensor6>
bufferization.dealloc_tensor %sp344 : tensor<?x3x4xf64, #Tensor4> bufferization.dealloc_tensor %sp344 : tensor<?x3x4xf64, #Tensor4>
bufferization.dealloc_tensor %sp345 : tensor<?x3x4xf64, #Tensor5> // bufferization.dealloc_tensor %sp345 : tensor<?x3x4xf64, #Tensor5>
bufferization.dealloc_tensor %sp346 : tensor<?x3x4xf64, #Tensor6> // bufferization.dealloc_tensor %sp346 : tensor<?x3x4xf64, #Tensor6>
bufferization.dealloc_tensor %s2p44 : tensor<2x?x4xf64, #Tensor4> // bufferization.dealloc_tensor %s2p44 : tensor<2x?x4xf64, #Tensor4>
bufferization.dealloc_tensor %s2p45 : tensor<2x?x4xf64, #Tensor5> bufferization.dealloc_tensor %s2p45 : tensor<2x?x4xf64, #Tensor5>
bufferization.dealloc_tensor %s2p46 : tensor<2x?x4xf64, #Tensor6> // bufferization.dealloc_tensor %s2p46 : tensor<2x?x4xf64, #Tensor6>
bufferization.dealloc_tensor %s23p4 : tensor<2x3x?xf64, #Tensor4> // bufferization.dealloc_tensor %s23p4 : tensor<2x3x?xf64, #Tensor4>
bufferization.dealloc_tensor %s23p5 : tensor<2x3x?xf64, #Tensor5> // bufferization.dealloc_tensor %s23p5 : tensor<2x3x?xf64, #Tensor5>
bufferization.dealloc_tensor %s23p6 : tensor<2x3x?xf64, #Tensor6> bufferization.dealloc_tensor %s23p6 : tensor<2x3x?xf64, #Tensor6>
bufferization.dealloc_tensor %s2pp4 : tensor<2x?x?xf64, #Tensor4> // bufferization.dealloc_tensor %s2pp4 : tensor<2x?x?xf64, #Tensor4>
bufferization.dealloc_tensor %s2pp5 : tensor<2x?x?xf64, #Tensor5> // bufferization.dealloc_tensor %s2pp5 : tensor<2x?x?xf64, #Tensor5>
bufferization.dealloc_tensor %s2pp6 : tensor<2x?x?xf64, #Tensor6> // bufferization.dealloc_tensor %s2pp6 : tensor<2x?x?xf64, #Tensor6>
return return
} }
} }