[InstSimplify] fold LoadInst for uniformaly initialized constant global variables

[khei4]

Summary

Fold loadInst for uniformly initialized global arrays.
Goal proof: https://alive2.llvm.org/ce/z/oZtVby
motivated by https://github.com/rust-lang/rust/issues/107208

[khei4]

add tests

[nikic]

Looks basically fine to me.

llvm/lib/Analysis/InstructionSimplify.cpp

6590

nit: regardless of?

6593

nit: Add a newline after this.

llvm/test/Transforms/InstSimplify/load.ll

58

I would add an additional test that shows that this can look through multiple GEPs and doesn't depend on the GEP source element type ([4 x i32]) either.

%gep1 = getelementptr inbounds i8, ptr @constzeroarray, i64 %idx1
%gep = getelementptr inbouds i8, ptr %gep1, i64 %idx2

[khei4]

Fix comments and add test cases.

[nikic]

I think something went wrong with the patch upload, it seems like only part of the test diff is there?

llvm/test/Transforms/InstSimplify/load.ll

64

Using i64 0 doesn't really make sense, because it is a no-op. The instruction will be removed before we get to the fold. It should use a variable index as well.

It's also fine to reuse constzeroarray rather than constzeroarrayi8 here -- in fact, that shows that we don't need a matching stride between the getelementptr and the globals declaration. (We do need it for the non-zero initializer case.)

87

Same here, getelementptr with zero index is a no-op.

[khei4]

I rebased commits and created a new diff. Maybe the cause is I combine the test commit and functional commit in the wrong way. I'm going to separate them next time.

[nikic]

LGTM. Could you please share the Name <email> to use for the commit?

[khei4]

Thanks a lot for review! Please use Kohei Asano <[e-mail]>.

llvm/test/Transforms/InstSimplify/load.ll

58

Seems reasonable. Thanks for the review!

64

Using i64 0 doesn't really make sense, because it is a no-op. The instruction will be removed before we get to the fold. It should use a variable index as well.

It's also fine to reuse constzeroarray rather than constzeroarrayi8 here -- in fact, that shows that we don't need a matching stride between the getelementptr and the globals declaration. (We do need it for the non-zero initializer case.)

Thanks. Used other variable indexes and reused constzeroarray for the second test case.

[khei4]

I noticed mistakenly reverted the review fix. Rebase.

llvm/lib/Analysis/InstructionSimplify.cpp

if (auto *PtrOpC = dyn_cast<Constant>(PtrOp))
     return ConstantFoldLoadFromConstPtr(PtrOpC, LI->getType(), Q.DL);
 
   // We can only fold the load if it is from a constant global with definitive
   // initializer. Skip expensive logic if this is not the case.
   auto *GV = dyn_cast<GlobalVariable>(getUnderlyingObject(PtrOp));
   if (!GV || !GV->isConstant() || !GV->hasDefinitiveInitializer())
     return nullptr;
 
+  // If GlobalVariable's initializer is uniform, then return the constant
+  // regardless its offset.
+  if (Constant *C =
+          ConstantFoldLoadFromUniformValue(GV->getInitializer(), LI->getType()))
+    return C;
   // Try to convert operand into a constant by stripping offsets while looking
   // through invariant.group intrinsics.
   APInt Offset(Q.DL.getIndexTypeSizeInBits(PtrOp->getType()), 0);
   PtrOp = PtrOp->stripAndAccumulateConstantOffsets(
       Q.DL, Offset, /* AllowNonInbounts */ true,
       /* AllowInvariantGroup */ true);
   if (PtrOp == GV) {
     // Index size may have changed due to address space casts.

llvm/test/Transforms/InstSimplify/load.ll

 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -passes=instsimplify -S | FileCheck %s
 
 @zeroinit = constant {} zeroinitializer
 @poison = constant {} poison
+
+
 @constzeroarray = internal constant [4 x i32] zeroinitializer
+@constzeroarrayi8 = internal constant [2 x i8] zeroinitializer
+
 @constarray = internal constant [4 x i32] [i32 1, i32 1, i32 1, i32 1]
+@constarrayi8 = internal constant [2 x i8] [i8 1, i8 1]
 
 define i32 @crash_on_zeroinit() {
 ; CHECK-LABEL: @crash_on_zeroinit(
 ; CHECK-NEXT:    ret i32 poison
 ;
   %load = load i32, ptr @zeroinit
   ret i32 %load
 }
;
   %1 = load <3 x float>, ptr getelementptr inbounds (<3 x float>, ptr @constvec, i64 1)
   ret <3 x float> %1
 }
 
 define i32 @load_gep_const_zero_array(i64 %idx) {
 ; CHECK-LABEL: @load_gep_const_zero_array(
 ; CHECK-NEXT:    ret i32 0
 ;
-  %gep = getelementptr inbounds [4 x i32], ptr @constzeroarray , i64 0, i64 %idx
+  %gep = getelementptr inbounds [4 x i32], ptr @constzeroarray, i64 0, i64 %idx
   %load = load i32, ptr %gep
   ret i32 %load
 }
 
+define i8 @load_gep_const_zero_array_i8(i64 %idx) {
+; CHECK-LABEL: @load_gep_const_zero_array_i8(
+; CHECK-NEXT:    ret i8 0
+;
+  %gep1 = getelementptr inbounds i8, ptr @constzeroarrayi8, i64 0
+  %gep = getelementptr inbounds i8, ptr %gep1, i64 %idx
+  %load = load i8, ptr %gep
+  ret i8 %load
+}
+
 define i32 @load_gep_const_array(i64 %idx) {
 ; CHECK-LABEL: @load_gep_const_array(
 ; CHECK-NEXT:    [[GEP:%.*]] = getelementptr inbounds [4 x i32], ptr @constarray, i64 0, i64 [[IDX:%.*]]
 ; CHECK-NEXT:    [[LOAD:%.*]] = load i32, ptr [[GEP]], align 4
 ; CHECK-NEXT:    ret i32 [[LOAD]]
 ;
-  %gep = getelementptr inbounds [4 x i32], ptr @constarray , i64 0, i64 %idx
+  %gep = getelementptr inbounds [4 x i32], ptr @constarray, i64 0, i64 %idx
   %load = load i32, ptr %gep
   ret i32 %load
 }
+
+define i8 @load_gep_const_array_i8(i64 %idx) {
+; CHECK-LABEL: @load_gep_const_array_i8(
+; CHECK-NEXT:    [[GEP:%.*]] = getelementptr inbounds i8, ptr @constarrayi8, i64 [[IDX:%.*]]
+; CHECK-NEXT:    [[LOAD:%.*]] = load i8, ptr [[GEP]], align 1
+; CHECK-NEXT:    ret i8 [[LOAD]]
+;
+  %gep1 = getelementptr inbounds i8, ptr @constarrayi8, i64 0
+  %gep = getelementptr inbounds i8, ptr %gep1, i64 %idx
+  %load = load i8, ptr %gep
+  ret i8 %load
+}