This is an archive of the discontinued LLVM Phabricator instance.

[llvm][DebugInfo] Add Annotations parameter to DIBuilder::createMethod
AcceptedPublic

Authored by Michael137 on Feb 16 2023, 5:26 AM.

Details

Reviewers
dblaikie
aprantl
Summary

This patch adds an optional Annotations paramter to
DIBuilder::createMethod which gets simply passed to the
DISubProgram constructor.

This will be used to attach abi-tag annotations to
constructors/destructors in a follow-up patch.

Diff Detail

Unit TestsFailed

Event Timeline

Michael137 created this revision.Feb 16 2023, 5:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2023, 5:26 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
Michael137 requested review of this revision.Feb 16 2023, 5:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2023, 5:26 AM
dblaikie accepted this revision.Feb 16 2023, 11:14 AM

Looks OK to me, pending the usage patch review - maybe hold off on committing this until that one's squared away.

This revision is now accepted and ready to land.Feb 16 2023, 11:14 AM