This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Extend readCOOIndices to support overhead types beyond index_type.
ClosedPublic

Authored by bixia on Feb 12 2023, 2:23 PM.

Details

Summary

This is to prepare for implementing the C API for reading a COO tensor to the
given buffers for indices and values.

Diff Detail

Event Timeline

bixia created this revision.Feb 12 2023, 2:23 PM
Herald added a project: Restricted Project. · View Herald Transcript
bixia requested review of this revision.Feb 12 2023, 2:23 PM
bixia updated this revision to Diff 496992.Feb 13 2023, 8:01 AM

Apply clang-format.

wrengr accepted this revision.Feb 13 2023, 11:37 AM
wrengr added inline comments.
mlir/include/mlir/ExecutionEngine/SparseTensor/File.h
269

Please rename rank to dimRank and rename r to d. (To make things forward compatible with the new terminology/style of D143800 and https://github.com/openxla/stablehlo/pull/1143)

This revision is now accepted and ready to land.Feb 13 2023, 11:37 AM
bixia updated this revision to Diff 497076.Feb 13 2023, 12:43 PM
bixia marked an inline comment as done.

Rename variables, rank => dimRank, r => d.