This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Remove unused ClangBuiltin definition for fmed3
ClosedPublic

Authored by foad on Feb 9 2023, 6:02 AM.

Details

Reviewers
arsenm
Group Reviewers
Restricted Project
Commits
rG7b4f361e56d2: [AMDGPU] Remove unused ClangBuiltin definition for fmed3
Summary

__builtin_amdgcn_fmed3 is unused since the actual builtins are
defined by Clang and have a floating point type suffix, h or f.

Diff Detail

Event Timeline

foad created this revision.Feb 9 2023, 6:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2023, 6:02 AM
foad requested review of this revision.Feb 9 2023, 6:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2023, 6:02 AM
arsenm accepted this revision.Feb 9 2023, 6:05 AM

It's really unfortunate we don't have a way to give a list of builtins for an intrinsic with type mangling

This revision is now accepted and ready to land.Feb 9 2023, 6:05 AM
This revision was landed with ongoing or failed builds.Feb 9 2023, 6:11 AM
This revision was automatically updated to reflect the committed changes.

The device library is using the builtin, so I assume the build will fail when this change lands.

Also, I see no median intrinsic described in the LLVM programming guide.

arsenm added a comment.Feb 9 2023, 7:35 AM

The device library is using the builtin, so I assume the build will fail when this change lands.

This doesn’t change the builtin at all

The device library is using the builtin, so I assume the build will fail when this change lands.

This doesn’t change the builtin at all

OK, sorry for the noise.