Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D143597

[clangd] Drop includes from disabled PP regions in preamble patch
ClosedPublic
Actions

Authored by kadircet on Feb 8 2023, 10:55 AM.

Details

Reviewers
sammccall
Commits
rG19659b5f0dd1: [clangd] Drop includes from disabled PP regions in preamble patch
Summary

In rest of the clangd functionality we treat these includes as
non-existent. Do so under preamble patching.

Depends on D143197

Diff Detail

Event Timeline

kadircet created this revision.Feb 8 2023, 10:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2023, 10:55 AM
Herald added a subscriber: arphaman. · View Herald Transcript
kadircet requested review of this revision.Feb 8 2023, 10:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2023, 10:55 AM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
kadircet mentioned this in D143197: [clangd] Fix bugs in main-file include patching for stale preambles.Feb 8 2023, 10:55 AM
Harbormaster completed remote builds in B212642: Diff 495888.Feb 8 2023, 11:14 AM
sammccall accepted this revision.Feb 8 2023, 9:10 PM
This revision is now accepted and ready to land.Feb 8 2023, 9:10 PM
Closed by commit rG19659b5f0dd1: [clangd] Drop includes from disabled PP regions in preamble patch (authored by kadircet). · Explain WhyFeb 13 2023, 12:49 AM
This revision was automatically updated to reflect the committed changes.
kadircet added a commit: rG19659b5f0dd1: [clangd] Drop includes from disabled PP regions in preamble patch.

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clangd/
15 lines
unittests/
9 lines

Diff 496860

View Options

clang-tools-extra/clangd/Preamble.cpp

Loading...
View Options

clang-tools-extra/clangd/unittests/PreambleTests.cpp

Loading...