This is a follow up to D110005 which covers compiler-rt variables.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Generally LGTM. I didn't check for potential mismatches across the patch, if there are other instances of the variables that need to be fixed, or if there are other variables that should be renamed though.
I did notice some inconsistencies and missing cases within the patch context though.
compiler-rt/cmake/config-ix.cmake | ||
---|---|---|
196 | What about this flag? | |
197 | This test is for C, not CXX |
What about this flag?