This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Unify compiler-rt flag variables
AcceptedPublic

Authored by phosek on Feb 4 2023, 10:23 PM.

Details

Reviewers
mstorsjo
Summary

This is a follow up to D110005 which covers compiler-rt variables.

Diff Detail

Event Timeline

phosek created this revision.Feb 4 2023, 10:23 PM
phosek requested review of this revision.Feb 4 2023, 10:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2023, 10:23 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
mstorsjo accepted this revision.Feb 8 2023, 1:30 PM

Generally LGTM. I didn't check for potential mismatches across the patch, if there are other instances of the variables that need to be fixed, or if there are other variables that should be renamed though.

I did notice some inconsistencies and missing cases within the patch context though.

compiler-rt/cmake/config-ix.cmake
196

What about this flag?

197

This test is for C, not CXX

This revision is now accepted and ready to land.Feb 8 2023, 1:30 PM