This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix quotation marks in overlay mode instructions
ClosedPublic

Authored by DavidSpickett on Feb 3 2023, 2:24 AM.

Details

Summary

These were using ” ("right double quotation mark") instead of
the usual ". This means CMake took the value literally and you
got:

CMake Error at CMakeLists.txt:139 (MESSAGE):
  ”libc” isn't a known project:
  bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;lld;lldb;mlir;openmp;polly;pstl;flang.
  Did you mean to enable it as a runtime in LLVM_ENABLE_RUNTIMES?

="libc" works fine.

Diff Detail

Event Timeline

DavidSpickett created this revision.Feb 3 2023, 2:24 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
DavidSpickett requested review of this revision.Feb 3 2023, 2:24 AM
DavidSpickett edited the summary of this revision. (Show Details)Feb 3 2023, 2:24 AM
DavidSpickett edited the summary of this revision. (Show Details)
lntue accepted this revision.Feb 3 2023, 6:35 AM
lntue added a reviewer: lntue.
This revision is now accepted and ready to land.Feb 3 2023, 6:35 AM