Paths

Table of Contentst

Differential D143161

[libc++][PSTL] Implement std::{any, all, none}_of
DraftPublic
Actions

Authored by philnik on Feb 2 2023, 2:40 AM.

Tags

Subscribers

This is a draft revision that has not yet been submitted for review.

Details

Reviewers

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	2,080 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 17'; clang-tidy-16 /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --checks='-,libcpp-' --load=/home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/libcxx/test/tools/clang_tidy_checks/libcxx-tidy.plugin -- -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fno-modules
	2,080 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 17'; clang-tidy-16 /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --checks='-,libcpp-' --load=/home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/libcxx/test/tools/clang_tidy_checks/libcxx-tidy.plugin -- -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fno-modules
	2,080 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 17'; clang-tidy-16 /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --checks='-,libcpp-' --load=/home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/libcxx/test/tools/clang_tidy_checks/libcxx-tidy.plugin -- -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fno-modules
	2,080 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 17'; clang-tidy-16 /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --checks='-,libcpp-' --load=/home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/libcxx/test/tools/clang_tidy_checks/libcxx-tidy.plugin -- -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fno-modules
	2,080 ms	libcxx CI C++03 > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp Script: -- : 'RUN: at line 17'; clang-tidy-16 /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --checks='-,libcpp-' --load=/home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/libcxx/test/tools/clang_tidy_checks/libcxx-tidy.plugin -- -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/857ec993b307-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++03 -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fno-modules
		View Full Test Results (38,025 Failed)

Event Timeline

philnik created this revision.Feb 2 2023, 2:40 AM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2023, 2:40 AM

Herald added a subscriber: miyuki. · View Herald Transcript

Harbormaster completed remote builds in B211430: Diff 494226.Feb 2 2023, 2:41 AM

philnik added a parent revision: D141888: [libc++][PSTL] Implement <execution> contents.Feb 6 2023, 9:45 AM

Try to fix CI

Harbormaster completed remote builds in B216228: Diff 500797.Mon, Feb 27, 8:11 AM

Try to fix CI

Harbormaster completed remote builds in B216521: Diff 501212.Tue, Feb 28, 10:21 AM

Try to fix CI

Harbormaster completed remote builds in B216621: Diff 501350.Tue, Feb 28, 6:19 PM

Fix header guard

Harbormaster completed remote builds in B216623: Diff 501352.Tue, Feb 28, 7:31 PM

Try to fix CI

Harbormaster completed remote builds in B216726: Diff 501525.Wed, Mar 1, 9:14 AM

ldionne added inline comments.Mon, Mar 13, 8:58 AM

libcxx/include/__algorithm/any_of.h
1	I would suggest splitting the PSTL `all_of`, `any_of` and `none_of` into a separate header to avoid impacting the dependencies of the basic `any_of` algorithm.
libcxx/include/execution
58	I would say no, as for most other extensions.

ldionne added inline comments.Mon, Mar 13, 9:34 AM

libcxx/test/std/algorithms/alg.nonmodifying/alg.any_of/pstl.any_of.pass.cpp
28	Like other algorithms, this should be tested on the different iterator categories.

ldionne mentioned this in D141779: [libc++][PSTL] Copy the headers into libc++.Mon, Mar 13, 9:39 AM

Revision Contents
Changeset List

Path

Size

libcxx/

include/

2 lines

__algorithm/

17 lines

40 lines

14 lines

__type_traits/

is_execution_policy.h

45 lines

	__utility/
	__algorithm/

	terminate_on_exception.h
	any_of.h

26 lines

44 lines

module.modulemap.in

1 line

pstl/

internal/

algorithm_fwd.h

23 lines

algorithm_impl.h

46 lines

glue_algorithm_defs.h

18 lines

glue_algorithm_impl.h

27 lines

parallel_backend_serial.h

8 lines

parallel_impl.h

7 lines

unseq_backend_simd.h

1 line

test/

libcxx/

private_headers.verify.cpp

2 lines

std/

algorithms/

alg.nonmodifying/

alg.all_of/

pstl.all_of.pass.cpp

53 lines

alg.any_of/

pstl.any_of.pass.cpp

53 lines

alg.none_of/

pstl.none_of.pass.cpp

53 lines

support/

test_execution_policies.h

31 lines

tools/

clang_tidy_checks/

2 lines

Diff 501525

libcxx/include/CMakeLists.txt

Loading...

libcxx/include/__algorithm/all_of.h

Loading...

libcxx/include/__algorithm/any_of.h

Loading...

libcxx/include/__algorithm/none_of.h

Loading...

libcxx/include/__type_traits/is_execution_policy.h

Loading...

libcxx/include/__utility/terminate_on_exception.h

Loading...

libcxx/include/execution

Loading...

libcxx/include/module.modulemap.in

Loading...

libcxx/include/pstl/internal/algorithm_fwd.h

Loading...

libcxx/include/pstl/internal/algorithm_impl.h

Loading...

libcxx/include/pstl/internal/glue_algorithm_defs.h

Loading...

libcxx/include/pstl/internal/glue_algorithm_impl.h

Loading...

libcxx/include/pstl/internal/parallel_backend_serial.h

Loading...

libcxx/include/pstl/internal/parallel_impl.h

Loading...

libcxx/include/pstl/internal/unseq_backend_simd.h

Loading...

libcxx/test/libcxx/private_headers.verify.cpp

Loading...

libcxx/test/std/algorithms/alg.nonmodifying/alg.all_of/pstl.all_of.pass.cpp

Loading...

libcxx/test/std/algorithms/alg.nonmodifying/alg.any_of/pstl.any_of.pass.cpp

Loading...

libcxx/test/std/algorithms/alg.nonmodifying/alg.none_of/pstl.none_of.pass.cpp

Loading...

libcxx/test/support/test_execution_policies.h

Loading...

libcxx/test/tools/clang_tidy_checks/CMakeLists.txt

Loading...