This is an archive of the discontinued LLVM Phabricator instance.

[libc++][PSTL] Integrate the headers and add a CI job
ClosedPublic

Authored by philnik on Jan 14 2023, 6:50 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG244560329603: [libc++][PSTL] Integrate the headers and add a CI job

Diff Detail

Event Timeline

philnik created this revision.Jan 14 2023, 6:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2023, 6:50 PM
Herald added a subscriber: arichardson. · View Herald Transcript
philnik updated this revision to Diff 489986.Jan 17 2023, 4:52 PM

Try to fix CI

philnik updated this revision to Diff 499130.Feb 21 2023, 5:43 AM
  • Rebased
  • Try to fix CI
philnik updated this revision to Diff 500204.Feb 24 2023, 7:47 AM

Try to fix CI

philnik updated this revision to Diff 500483.Feb 25 2023, 5:03 PM

Try to fix CI

philnik retitled this revision from [libc++][PSTL] Integrate the headers and add a CI to [libc++][PSTL] Integrate the headers and add a CI job.Apr 16 2023, 3:08 PM
philnik updated this revision to Diff 516967.Apr 25 2023, 4:05 PM

Try to fix CIx

ldionne published this revision for review.Apr 26 2023, 9:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 26 2023, 9:08 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested changes to this revision.Apr 26 2023, 9:19 AM
ldionne added inline comments.
libcxx/cmake/caches/With-pstl.cmake
2–3

These should be removed once we move to -fexperimental-library. Can you add a comment?

Actually, this whole CI job is going to go away once we move to -fexperimental-library for the PSTL.

libcxx/include/CMakeLists.txt
869

Can we rename all of those to __pstl/FOOOO immediately after this patch? I'd be fine with doing it before as well, both ways work.

954

Not needed anymore.

libcxx/include/pstl/internal/pstl_config.h
13–14

I would remove __pstl_config_site entirely and define _PSTL_PAR_BACKEND_SERIAL temporarily, like you do right now.

libcxx/utils/libcxx/test/features.py
212
This revision now requires changes to proceed.Apr 26 2023, 9:19 AM
ldionne accepted this revision.Apr 26 2023, 9:20 AM

Actually, LGTM w/ comments addressed.

This revision is now accepted and ready to land.Apr 26 2023, 9:20 AM
ldionne added inline comments.Apr 26 2023, 9:32 AM
libcxx/utils/libcxx/test/features.py
212

In retrospect, we probably do need to keep a with-pstl Lit feature temporarily until we enable it via -fexperimental-library. So I would keep it, but I would *also* introduce FIXME-PSTL-INTEGRATION cause those are semantically different.

philnik updated this revision to Diff 517229.Apr 26 2023, 10:25 AM
philnik marked 5 inline comments as done.

Address comments

philnik updated this revision to Diff 517239.Apr 26 2023, 10:44 AM

Try to fix CI

This revision was landed with ongoing or failed builds.Apr 26 2023, 1:11 PM
This revision was automatically updated to reflect the committed changes.