This is an archive of the discontinued LLVM Phabricator instance.

Differential D143101

[BOLT][CMake] Add dependency on llvm_vcsrevision_h
ClosedPublic

Authored by Amir on Feb 1 2023, 12:37 PM.

Details

Reviewers
nathanchance
rafauler
maksfb
ayermolo
Group Reviewers
Restricted Project
Commits
rG4177e8935464: [BOLT][CMake] Add dependency on llvm_vcsrevision_h
Summary

The dependence is needed since Utils includes VCSRevision.h, and other
LLVM components that include this header also have the llvm_vcsrevision_h
dependency.

Fixes #60460.

Diff Detail

Event Timeline

Amir created this revision.Feb 1 2023, 12:37 PM
Herald added a reviewer: rafauler. · View Herald TranscriptFeb 1 2023, 12:37 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
Amir requested review of this revision.Feb 1 2023, 12:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 12:37 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
ayermolo accepted this revision.Feb 1 2023, 12:41 PM
This revision is now accepted and ready to land.Feb 1 2023, 12:41 PM
Harbormaster completed remote builds in B211291: Diff 494038.Feb 1 2023, 12:52 PM
Closed by commit rG4177e8935464: [BOLT][CMake] Add dependency on llvm_vcsrevision_h (authored by Amir). · Explain WhyFeb 1 2023, 12:58 PM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG4177e8935464: [BOLT][CMake] Add dependency on llvm_vcsrevision_h.

Revision Contents

PathSize
bolt/
lib/
Utils/
3 lines

Diff 494047

bolt/lib/Utils/CMakeLists.txt

add_llvm_library(LLVMBOLTUtils add_llvm_library(LLVMBOLTUtils
CommandLineOpts.cpp CommandLineOpts.cpp
Utils.cpp Utils.cpp
DISABLE_LLVM_LINK_LLVM_DYLIB DISABLE_LLVM_LINK_LLVM_DYLIB
LINK_LIBS LINK_LIBS
${LLVM_PTHREAD_LIB} ${LLVM_PTHREAD_LIB}
DEPENDS
llvm_vcsrevision_h
LINK_COMPONENTS LINK_COMPONENTS
Support Support
) )