This is an archive of the discontinued LLVM Phabricator instance.

[Libomptarget] Fix disabling amdgpu on non-Linux.
ClosedPublic

Authored by sthibaul on Jan 31 2023, 2:10 PM.

Details

Summary

Previously, on non-Linux, amdgpu would get enabled whatever the CPU architecture.

Diff Detail

Event Timeline

sthibaul created this revision.Jan 31 2023, 2:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 2:10 PM
sthibaul requested review of this revision.Jan 31 2023, 2:10 PM

(This apparently dates back up to llvm 15)

jhuber6 accepted this revision.Jan 31 2023, 2:12 PM

Didn't know we even attempted to build libomptarget on non-Linux yet. Maybe some day we'll have it working on Windows.

This revision is now accepted and ready to land.Jan 31 2023, 2:12 PM

FI I don't have commit access

FI I don't have commit access

What's your github email.

I'm samuel.thibault@ens-lyon.org there

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2023, 5:45 AM