This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp
ClosedPublic

Authored by barannikov88 on Jan 31 2023, 2:54 AM.

Diff Detail

Event Timeline

barannikov88 created this revision.Jan 31 2023, 2:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 2:54 AM
barannikov88 requested review of this revision.Jan 31 2023, 2:54 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 31 2023, 2:54 AM
foad added a comment.Jan 31 2023, 3:35 AM

Looks OK but what's the motivation for it?

foad added inline comments.Jan 31 2023, 3:37 AM
clang/docs/tools/clang-formatted-files.txt
7421

Should come after CodeBeads in alphabetical order?

barannikov88 added a comment.EditedJan 31 2023, 3:55 AM

I intent to make make InstAlias with "complex" operands (non-empty MIOperandInfo) more robust (stricter syntax). There is also a couple of bugs I'd like to fix.
The change will clobber most of the code here, and I thought it is a good time to move the class to a dedicated file.
Another weak point is that this class is only used in AsmMatcherEmitter and AsmWriterEmitter, while CodeGenInstruction.h is included everywhere.
The class does not have long history; there were only a few functional changes since initial commit.

That is, no strong motivation.

foad accepted this revision.Jan 31 2023, 4:55 AM

Seems reasonable.

This revision is now accepted and ready to land.Jan 31 2023, 4:55 AM
This revision was landed with ongoing or failed builds.Jan 31 2023, 6:23 PM
This revision was automatically updated to reflect the committed changes.