Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| mlir/lib/Dialect/SparseTensor/Transforms/SparseBufferRewriting.cpp | ||
|---|---|---|
| 685 | has index type (not an, there is only one) | |
| 697 | The generated | |
| 706 | the ++ are not on the variables | |
| 706 | the comment that the right child exists does not apply to L706, so it should be moved as header of the if-statement | |
| 747 | since you do this twice, would a helper make this shorter? | |
Fix comments to address review feedback.
| mlir/lib/Dialect/SparseTensor/Transforms/SparseBufferRewriting.cpp | ||
|---|---|---|
| 747 | The two if ((n-2)/2==child) look the same in c but different in MLIR, as the second one needs to yields (child, childIdx) so support the enclosing while-stmt. So I have a helper lambda to generate getLargerChild instead. | |
has index type (not an, there is only one)