Page MenuHomePhabricator

[flang] Use clang sysroot image to test fastmath linking
ClosedPublic

Authored by tblah on Jan 28 2023, 5:53 AM.

Details

Summary

This test has been very unreliable across different machines. Update it
to use clang's sysroot image so that the fastmath object file name is
stable across different distributions and distro types.

Based on clang/test/Driver/linux-ld.c

Thanks to mnadeem for pointing this out at https://reviews.llvm.org/D138675

Diff Detail

Event Timeline

tblah created this revision.Jan 28 2023, 5:53 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 28 2023, 5:53 AM
Herald added a subscriber: sunshaoce. · View Herald Transcript
tblah requested review of this revision.Jan 28 2023, 5:53 AM
mnadeem accepted this revision.Feb 7 2023, 12:12 PM
mnadeem added inline comments.
flang/test/Driver/fast_math.f90
61

We can probably get rid of this as the test now specifies a fixed x86 linux target.

64

I guess reusing the clang tree is fine.

This revision is now accepted and ready to land.Feb 7 2023, 12:12 PM
This revision was automatically updated to reflect the committed changes.