This is an archive of the discontinued LLVM Phabricator instance.

Differential D142807

[flang] Use clang sysroot image to test fastmath linking
ClosedPublic

Authored by tblah on Jan 28 2023, 5:53 AM.

Details

Reviewers
mnadeem
kiranchandramohan
awarzynski
Commits
rG09216cfdab87: [flang] Use clang sysroot image to test fastmath linking
Summary

This test has been very unreliable across different machines. Update it
to use clang's sysroot image so that the fastmath object file name is
stable across different distributions and distro types.

Based on clang/test/Driver/linux-ld.c

Thanks to mnadeem for pointing this out at https://reviews.llvm.org/D138675

Diff Detail

Event Timeline

tblah created this revision.Jan 28 2023, 5:53 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 28 2023, 5:53 AM
Herald added a subscriber: sunshaoce. · View Herald Transcript
tblah requested review of this revision.Jan 28 2023, 5:53 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptJan 28 2023, 5:53 AM
tblah mentioned this in D138675: [flang] Add -ffast-math and -Ofast.Jan 28 2023, 5:54 AM
Harbormaster completed remote builds in B210534: Diff 492996.Jan 28 2023, 6:11 AM
tblah added a comment.Feb 6 2023, 3:14 AM

ping @mnadeem

mnadeem accepted this revision.Feb 7 2023, 12:12 PM
mnadeem added inline comments.
flang/test/Driver/fast_math.f90
71

We can probably get rid of this as the test now specifies a fixed x86 linux target.

74

I guess reusing the clang tree is fine.

This revision is now accepted and ready to land.Feb 7 2023, 12:12 PM
Closed by commit rG09216cfdab87: [flang] Use clang sysroot image to test fastmath linking (authored by tblah). · Explain WhyFeb 8 2023, 2:09 AM
This revision was automatically updated to reflect the committed changes.
tblah added a commit: rG09216cfdab87: [flang] Use clang sysroot image to test fastmath linking.

Revision Contents

PathSize
flang/
test/
Driver/
2 lines

Diff 495767

flang/test/Driver/fast_math.f90

Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Lines
! Check that -fno-fast-math doesn't clobber -ffp-contract ! Check that -fno-fast-math doesn't clobber -ffp-contract
! RUN: %flang -ffp-contract=off -fno-fast-math -fsyntax-only -### %s -o %t 2>&1 \ ! RUN: %flang -ffp-contract=off -fno-fast-math -fsyntax-only -### %s -o %t 2>&1 \
! RUN: | FileCheck --check-prefix=CHECK-CONTRACT %s ! RUN: | FileCheck --check-prefix=CHECK-CONTRACT %s
! CHECK-CONTRACT: -fc1 ! CHECK-CONTRACT: -fc1
! CHECK-CONTRACT-SAME: -ffp-contract=off ! CHECK-CONTRACT-SAME: -ffp-contract=off
! Check that -ffast-math causes us to link to crtfastmath.o ! Check that -ffast-math causes us to link to crtfastmath.o
! UNSUPPORTED: system-windows ! UNSUPPORTED: system-windows
! UNSUPPORTED: target=powerpc{{.*}} ! UNSUPPORTED: target=powerpc{{.*}}
mnadeemUnsubmitted
Not Done
ReplyInline Actions

We can probably get rid of this as the test now specifies a fixed x86 linux target.

mnadeem: We can probably get rid of this as the test now specifies a fixed x86 linux target.
! RUN: %flang -ffast-math -### %s -o %t 2>&1 \ ! RUN: %flang -ffast-math -### %s -o %t 2>&1 \
! RUN: --target=x86_64-unknown-linux -no-pie --gcc-toolchain="" \
! RUN: --sysroot=%S/../../../clang/test/Driver/Inputs/basic_linux_tree \
mnadeemUnsubmitted
Not Done
ReplyInline Actions

I guess reusing the clang tree is fine.

mnadeem: I guess reusing the clang tree is fine.
! RUN: | FileCheck --check-prefix=CHECK-CRT %s ! RUN: | FileCheck --check-prefix=CHECK-CRT %s
! CHECK-CRT: {{crtbegin.?\.o}} ! CHECK-CRT: {{crtbegin.?\.o}}
! CHECK-CRT-SAME: crtfastmath.o ! CHECK-CRT-SAME: crtfastmath.o
! CHECK-CRT-SAME: {{crtend.?\.o}} ! CHECK-CRT-SAME: {{crtend.?\.o}}