Currently, all the non-stable sorting algorithms are implemented via the
straightforward quick sort. This will be fixed in the following PR.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorAttrDefs.td | ||
|---|---|---|
| 332 | I think part of the TODO should be here. Also, can you add the table you shared during the internal discussions here in ASCII format (sorting vs. stable property) | |
| mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorOps.td | ||
|---|---|---|
| 589 | This is also a TODO, but I think you should put it at the attribute doc, not here | |
Move a TODO to the enum definition. Add a table to show the 8 values for (stabl|nonstable, sort).
| mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorAttrDefs.td | ||
|---|---|---|
| 332 | Move the TODO to here and add the table. | |
| mlir/include/mlir/Dialect/SparseTensor/IR/SparseTensorAttrDefs.td | ||
|---|---|---|
| 337 | Shouldn't have an underscore here, since that's not used when naming any of the other options | |
I think part of the TODO should be here. Also, can you add the table you shared during the internal discussions here in ASCII format (sorting vs. stable property)