[flang] Fixed uninitialized std::unique_ptr dereference.

[vzakhari]

Summary

This fixes unittest failures reported in D142279:

flang-Unit :: Frontend/./FlangFrontendTests/5/7
flang-Unit :: Frontend/./FlangFrontendTests/6/7

[awarzynski]

LGTM, thanks for fixing this!

[foad]

flang/lib/Frontend/FrontendActions.cpp

784

How about refactoring this so we don't have to keep repeating ci.isOutputStreamNull() ? *os : ci.getOutputStream()?

[foad]

I see this was landed in e054e0da9fd7055142188036ee713e8c0697324b

[vzakhari]

In D142671#4085198, @foad wrote:

I see this was landed in e054e0da9fd7055142188036ee713e8c0697324b

Sorry, it looks like it went in after an awkward arc invocation for D142652. I was going to wait for the review before merging it.

[foad]

In D142671#4085885, @vzakhari wrote:

In D142671#4085198, @foad wrote:

I see this was landed in e054e0da9fd7055142188036ee713e8c0697324b

Sorry, it looks like it went in after an awkward arc invocation for D142652. I was going to wait for the review before merging it.

No problem, I just noted it here for future reference. Thanks for the fix.

flang/lib/Frontend/FrontendActions.cpp

void CodeGenAction::executeAction() {
   }
   // Always set the triple and data layout, to make sure they match and are set.
   // Note that this overwrites any datalayout stored in the LLVM-IR. This avoids
   // an assert for incompatible data layout when the code-generation happens.
   llvmModule->setTargetTriple(theTriple);
   llvmModule->setDataLayout(tm->createDataLayout());
 
   // Run LLVM's middle-end (i.e. the optimizer).
-  runOptimizationPipeline(*os);
+  runOptimizationPipeline(ci.isOutputStreamNull() ? *os : ci.getOutputStream());
 
   if (action == BackendActionTy::Backend_EmitLL) {
     llvmModule->print(ci.isOutputStreamNull() ? *os : ci.getOutputStream(),
                       /*AssemblyAnnotationWriter=*/nullptr);
     return;
   }
 
   if (action == BackendActionTy::Backend_EmitBC) {